Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused last_modified attribute #108

Open
tlater-famedly opened this issue Jan 22, 2025 · 0 comments
Open

Deprecate unused last_modified attribute #108

tlater-famedly opened this issue Jan 22, 2025 · 0 comments
Labels
tech debt Work on this should be planned according to tech debt policy Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality.

Comments

@tlater-famedly
Copy link
Contributor

We do not use the last_modified attribute defined here for anything anymore: https://github.com/famedly/famedly-sync/blob/main/src/sources/ldap.rs#L319

Its purpose was to tell ldap_poller which changes should be considered, since it fundamentally relied on processing the user list over time, however we have switched to a full sync algorithm as that is more robust to partial/interrupted syncs. As such, it no longer serves a purpose, and we shouldn't force users to define it.

This will be a breaking change, though we can simply ignore the attribute when it exists, and otherwise remove it from all our documentation.

@tlater-famedly tlater-famedly added Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality. tech debt Work on this should be planned according to tech debt policy labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Work on this should be planned according to tech debt policy Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality.
Projects
None yet
Development

No branches or pull requests

1 participant