ConnectKitButton.Custom should not be using children props #23
Locked
GabrielCartier
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
@GabrielCartier Hey, thanks for raising! Right now
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It's generally not a good idea to use
children
props, it is recommended to use children component instead. There are someeslint
rules that will actually warn you about that (react/no-children-prop
).I think passing the children directly into the
ConnectKitButton.Custom
would be a more react design.It would mean you would have to pass some of the props from one component to another but you could have all those props autocomplete in an easy way vs. using the
renderProps
.Beta Was this translation helpful? Give feedback.
All reactions