Skip to content

Commit

Permalink
Upgrade to Node.js 16 (#542)
Browse files Browse the repository at this point in the history
* Upgrade to Node.js 16

* more mem

* require node 16
  • Loading branch information
tovbinm authored Jun 20, 2022
1 parent dab208b commit 88385ad
Show file tree
Hide file tree
Showing 35 changed files with 67 additions and 80 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,14 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16

- name: Install dependencies
run: npm install -g npm@7 lerna && lerna bootstrap --hoist
run: npm install -g lerna && lerna bootstrap --hoist

- name: Test
env:
NODE_OPTIONS: "--max-old-space-size=4096"
run: lerna run test-cov

- name: Run Jenkins server
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
registry-url: https://registry.npmjs.org

- name: Extract tag version
Expand All @@ -32,7 +32,7 @@ jobs:
echo "TAG_VERSION=$TAG_VERSION" >> $GITHUB_ENV
- name: Install dependencies
run: npm install -g npm@7 lerna && lerna bootstrap --hoist
run: npm install -g lerna && lerna bootstrap --hoist

- name: Publish Airbyte CDK package
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM node:14-alpine
FROM node:16-alpine

WORKDIR /home/node/airbyte
RUN npm install -g npm@7 lerna tsc
RUN npm install -g lerna tsc

COPY lerna.json .tsconfig.json package.json package-lock.json ./
RUN sed -i "/jest\|mockttp/d" package.json
Expand Down
13 changes: 6 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ See the READMEs inside `destinations/` and `sources/` subfolders for more inform
# Development

1. Install [`nvm`](https://github.com/nvm-sh/nvm#installing-and-updating)
2. Install Node.js `nvm install 14 && nvm use 14`
3. Update `npm` to version 7.x by running `npm install -g npm@7`
4. Install `lerna` by running `npm install -g lerna`
5. Run `npm run prepare` to install dependencies for all projects (`npm run clean` to clean all)
6. Run `npm run build` to build all projects (for a single project add scope, e.g `npm run build -- --scope airbyte-faros-destination`)
7. Run `npm run test` to test all projects (for a single project add scope, e.g `npm run test -- --scope airbyte-faros-destination`)
8. Run `npm run lint` to apply linter on all projects (for a single project add scope, e.g `npm run lint -- --scope airbyte-faros-destination`)
2. Install Node.js `nvm install 16 && nvm use 16`
3. Install `lerna` by running `npm install -g lerna`
4. Run `npm run prepare` to install dependencies for all projects (`npm run clean` to clean all)
5. Run `npm run build` to build all projects (for a single project add scope, e.g `npm run build -- --scope airbyte-faros-destination`)
6. Run `npm run test` to test all projects (for a single project add scope, e.g `npm run test -- --scope airbyte-faros-destination`)
7. Run `npm run lint` to apply linter on all projects (for a single project add scope, e.g `npm run lint -- --scope airbyte-faros-destination`)

👉 Follow our guide on how to develop a new source [here](https://github.com/faros-ai/airbyte-connectors/tree/main/sources#developing-an-airbyte-source).

Expand Down
4 changes: 2 additions & 2 deletions destinations/airbyte-faros-destination/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
],
"main": "./lib",
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"scripts": {
"build": "tsc -p src",
Expand All @@ -37,7 +37,7 @@
"axios": "^0.26.0",
"date-format": "^4.0.6",
"faros-airbyte-cdk": "0.0.1",
"faros-feeds-sdk": "^0.11.6",
"faros-feeds-sdk": "^0.12.0",
"fs-extra": "^10.0.0",
"git-url-parse": "^11.6.0",
"json-to-graphql-query": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion faros-airbyte-cdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
],
"main": "./lib",
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"scripts": {
"build": "tsc -p src",
Expand Down
56 changes: 21 additions & 35 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/jest": "^27.5.0",
"@types/lodash": "^4.14.173",
"@types/luxon": "^2.3.2",
"@types/node": "^14.14.20",
"@types/node": "^16.11.41",
"@types/parse-link-header": "2.0.0",
"@types/pino": "^7.0.5",
"@types/toposort": "^2.0.3",
Expand All @@ -42,6 +42,6 @@
"ts-essentials": "^9.1.2",
"ts-jest": "^27.1.3",
"ts-node": "^10.8.1",
"typescript": "^4.7.3"
"typescript": "^4.7.4"
}
}
2 changes: 1 addition & 1 deletion sources/agileaccelerator-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/azure-repos-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/azureactivedirectory-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/azurepipeline-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/backlog-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/bamboohr-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/bitbucket-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/buildkite-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/circleci-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/customer-io-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/datadog-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/docker-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/example-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/firehydrant-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/gitlab-ci-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/googlecalendar-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion sources/harness-source/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"resources/"
],
"engines": {
"node": ">=14.5"
"node": ">=16"
},
"main": "./lib",
"scripts": {
Expand Down
Loading

0 comments on commit 88385ad

Please sign in to comment.