Remove unlink since it's covered by temp + make tests work with Node …

…16 (#541)
faros-ai · Jun 18, 2022 · ca4ef31 · ca4ef31
1 parent 1c503d5
commit ca4ef31
Show file tree

Hide file tree

Showing 38 changed files with 207 additions and 290 deletions.
diff --git a/destinations/airbyte-faros-destination/test/converters/agileaccelerator.test.ts b/destinations/airbyte-faros-destination/test/converters/agileaccelerator.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('agileaccelerator', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/asana.test.ts b/destinations/airbyte-faros-destination/test/converters/asana.test.ts
@@ -31,7 +31,6 @@ describe('asana', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -166,7 +165,6 @@ describe('asana', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/azure-repos.test.ts b/destinations/airbyte-faros-destination/test/converters/azure-repos.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('azure-repos', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/azureactivedirectory.test.ts b/destinations/airbyte-faros-destination/test/converters/azureactivedirectory.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('azureactivedirectory', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/azurepipeline.test.ts b/destinations/airbyte-faros-destination/test/converters/azurepipeline.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('azurepipeline', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/backlog.test.ts b/destinations/airbyte-faros-destination/test/converters/backlog.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('backlog', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/bamboohr.test.ts b/destinations/airbyte-faros-destination/test/converters/bamboohr.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('bamboohr', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/bitbucket.test.ts b/destinations/airbyte-faros-destination/test/converters/bitbucket.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('bitbucket', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/buildkite.test.ts b/destinations/airbyte-faros-destination/test/converters/buildkite.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('buildkite', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/circleci.test.ts b/destinations/airbyte-faros-destination/test/converters/circleci.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('circleci', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/datadog.test.ts b/destinations/airbyte-faros-destination/test/converters/datadog.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal, MockedEndpoint} from 'mockttp';
 import pino from 'pino';
@@ -46,7 +45,6 @@ describe('datadog', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/docker.test.ts b/destinations/airbyte-faros-destination/test/converters/docker.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -35,7 +34,6 @@ describe('docker', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/faros_feeds.test.ts b/destinations/airbyte-faros-destination/test/converters/faros_feeds.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('faros_feeds', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/firehydrant.test.ts b/destinations/airbyte-faros-destination/test/converters/firehydrant.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal, MockedEndpoint} from 'mockttp';
 import pino from 'pino';
@@ -39,7 +38,6 @@ describe('firehydrant', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/github.test.ts b/destinations/airbyte-faros-destination/test/converters/github.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -31,7 +30,6 @@ describe('github', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -166,7 +164,6 @@ describe('github', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/gitlab-ci.test.ts b/destinations/airbyte-faros-destination/test/converters/gitlab-ci.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -31,7 +30,6 @@ describe('gitlab-ci', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -166,7 +164,6 @@ describe('gitlab-ci', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/gitlab.test.ts b/destinations/airbyte-faros-destination/test/converters/gitlab.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -31,7 +30,6 @@ describe('gitlab', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -166,7 +164,6 @@ describe('gitlab', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/googlecalendar.test.ts b/destinations/airbyte-faros-destination/test/converters/googlecalendar.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -51,7 +50,6 @@ describe('googlecalendar', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/harness.test.ts b/destinations/airbyte-faros-destination/test/converters/harness.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -28,7 +27,6 @@ describe('harness', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('skip to process bad records when strategy is SKIP', async () => {
@@ -64,7 +62,6 @@ describe('harness', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/jenkins.test.ts b/destinations/airbyte-faros-destination/test/converters/jenkins.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -30,7 +29,6 @@ describe('jenkins', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -145,7 +143,6 @@ describe('jenkins', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/jira.test.ts b/destinations/airbyte-faros-destination/test/converters/jira.test.ts
@@ -44,7 +44,6 @@ describe('jira', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('check valid jira source config', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/okta.test.ts b/destinations/airbyte-faros-destination/test/converters/okta.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal, MockedEndpoint} from 'mockttp';
 import pino from 'pino';
@@ -39,7 +38,6 @@ describe('okta', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/opsgenie.test.ts b/destinations/airbyte-faros-destination/test/converters/opsgenie.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal, MockedEndpoint} from 'mockttp';
 import pino from 'pino';
@@ -39,7 +38,6 @@ describe('opsgenie', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {

diff --git a/destinations/airbyte-faros-destination/test/converters/pagerduty.test.ts b/destinations/airbyte-faros-destination/test/converters/pagerduty.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel, AirbyteRecord} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import os from 'os';
@@ -30,7 +29,6 @@ describe('pagerduty', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process and write records', async () => {
@@ -144,7 +142,6 @@ describe('pagerduty', () => {
   });
 
   test('fail to process bad records when strategy is FAIL', async () => {
-    fs.unlinkSync(configPath);
     configPath = await tempConfig(mockttp.url, InvalidRecordStrategy.FAIL);
     const cli = await CLI.runWith([
       'write',

diff --git a/destinations/airbyte-faros-destination/test/converters/phabricator.test.ts b/destinations/airbyte-faros-destination/test/converters/phabricator.test.ts
@@ -1,5 +1,4 @@
 import {AirbyteLog, AirbyteLogLevel} from 'faros-airbyte-cdk';
-import fs from 'fs';
 import _ from 'lodash';
 import {getLocal} from 'mockttp';
 import pino from 'pino';
@@ -26,7 +25,6 @@ describe('phabricator', () => {
 
   afterEach(async () => {
     await mockttp.stop();
-    fs.unlinkSync(configPath);
   });
 
   test('process records from all streams', async () => {