🐛 Fix test failed after test_reset_password if user use own password #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If use set his own password of FIRST_SUPERUSER_PASSWORD in .env file, after run test_reset_password case, the password will be changed to "changethis" becasue it hardcorded in this testcase. Following testcases will all be failed because of wrong password. Change it to reset to password in .env file.
alejsdev
changed the title
|
Hi @andyyoung01, this was already handled in #1499 by refactoring the whole test. I'll close this one but thanks for your effort. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user set password of FIRST_SUPERUSER_PASSWORD to a different value of "changethis" in .env file, after run test_reset_password case, the password will be changed to "changethis" becasue it hardcorded in this testcase.
Following testcases will all be failed because of wrong password.
Change it to reset to password in .env file.