[BUG] Completion of error handling

[elfring]

Would you like to add more error handling for return values from functions like the following?

• printf ⇒ printCommandFormatHelp
• malloc ⇒ ffGetFileVersion
• realloc ⇒ ffListAdd

[CarterLi]

No. We dont check results of *allocs. Just let the program crash if they fail.

[CarterLi]

BTW what static checker are you using?

[elfring]

💭 I hope that you would like to avoid undefined behaviour.
How do you think about to improve static source code analysis also for this software? 🤔

[CarterLi]

In modern system, malloc should almost never fail because swap exists. One exception is programming bug such as malloc(-1). In this case I would rather let the program to crash and generate some stack traces or core dump file so I can find where the bug is and fix it.

[elfring]

💭 Some software users tend to prefer defined behaviour.

---

Some functions are known where return values can be overlooked.
👀 Thus questionable places can be found also by the means of GitHub source code search interfaces.

[CarterLi]

Modern compilers are already smart enough to detect some UBs. We also use ASAN and UBSAN. I think it's enough for me.

[elfring]

🔮 How will chances evolve to benefit any more also from the means of aspect-oriented software development?