Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start indexing homepage and sub-pages (not just blog articles) #21

Closed
etagwerker opened this issue Jun 20, 2023 · 2 comments
Closed

Start indexing homepage and sub-pages (not just blog articles) #21

etagwerker opened this issue Jun 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@etagwerker
Copy link
Member

Current

Right now we are indexing only blog articles via the blog's sitemap.

Expected

We want to expand the reach of the indexing mechanism to include all pages (not just blog)

Biz Goal

That way we can later quickly generate shareable links to homepage and internal pages.

@etagwerker etagwerker added the enhancement New feature or request label Jul 23, 2023
@fbuys fbuys self-assigned this Oct 3, 2023
fbuys added a commit that referenced this issue Oct 3, 2023
Previously we only included links that end with `.html` from the
different sitemaps. Now we include all pages.

The same conditions used to exclude some specifig pages from our index
has been left in place.
Code: `.reject {|x| x.include?("page") || x.include?("/tags/") || x.include?("author") }`

See: #21
@fbuys
Copy link
Contributor

fbuys commented Oct 3, 2023

I have submitted a PR over here: #27

fbuys added a commit that referenced this issue Oct 4, 2023
Previously we only included links that end with `.html` from the
different sitemaps. Now we include all pages.

The same conditions used to exclude some specifig pages from our index
has been left in place. We also exclude URLs with a hash param.
Reject condition: `x.match?(/#.+\z/) || x.include?('page') || x.include?('/tags/') || x.include?('author')`

See: #21
fbuys added a commit that referenced this issue Oct 6, 2023
Previously we only included links that end with `.html` from the
different sitemaps. Now we include all pages.

The same conditions used to exclude some specifig pages from our index
has been left in place. We also exclude URLs with a hash param.
Reject condition: `x.match?(/#.+\z/) || x.include?('page') || x.include?('/tags/') || x.include?('author')`

We removed the where condition in the links_controller.
Now links without published_at will show.
This also means that links without  published_at will appear at the top
of the links page.
See: https://stackoverflow.com/a/44912964

See: #21
fbuys added a commit that referenced this issue Oct 6, 2023
Previously we only included links that end with `.html` from the
different sitemaps. Now we include all pages.

The same conditions used to exclude some specifig pages from our index
has been left in place. We also exclude URLs with a hash param.
Reject condition: `x.match?(/#.+\z/) || x.include?('page') || x.include?('/tags/') || x.include?('author')`

We removed the where condition in the links_controller.
Now links without published_at will show.
This also means that links without  published_at will appear at the top
of the links page.
See: https://stackoverflow.com/a/44912964

See: #21
etagwerker pushed a commit that referenced this issue Oct 6, 2023
Previously we only included links that end with `.html` from the
different sitemaps. Now we include all pages.

The same conditions used to exclude some specifig pages from our index
has been left in place. We also exclude URLs with a hash param.
Reject condition: `x.match?(/#.+\z/) || x.include?('page') || x.include?('/tags/') || x.include?('author')`

We removed the where condition in the links_controller.
Now links without published_at will show.
This also means that links without  published_at will appear at the top
of the links page.
See: https://stackoverflow.com/a/44912964

See: #21
@etagwerker
Copy link
Member Author

Closed by #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants