Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to disable typing consonant twice making it double consonant #12

Open
scarf005 opened this issue Sep 9, 2024 · 16 comments
Open

Comments

@scarf005
Copy link

scarf005 commented Sep 9, 2024

Situation

ㄱ + ㄱ -> ㄲ

typing consonant, then the same consonant again, makes it a double consonant. this make typing multiple consonant simultaneously difficult (e.g gets typed when desired output is ㄱㄱ). it would be great to disable this behavior as many other input methods (windows IME, ibus) doesn't.

image

afaik fcitx5 does not have an option to disable this behavior.

System info

  • OS: Fedora 40 (kinoite)
  • Kernel: 6.10.6
  • fcitx5: 5.1.10

What others think of this issue

fcitx 쓰다가 maintenance mode 들어가서 fcitx5로 갈아타서 현재도 계속 쓰고 있습니다. 같은 자음 두번 입력하면 강제로 쌍자음으로 바뀌는 거 말고는 만족스러워서 사용을 하게 됩니다.
translated: I was using fcitx, but it entered maintenance mode, so I switched to fcitx5 and am still using it. I'm satisfied with it, except for the issue where typing the same consonant twice forces it to change into a double consonant.

https://discourse.ubuntu-kr.org/t/q/48676/9

기본 입력기들과 nimf를 깔아본 결과 기본 입력기인 fcitx가 제일 안정적이어서 그대로 쓰고있습니다.
다만 한가지 걸리는게 바로 쌍자음인데요..
같은 키를 두 번 누르면 쌍자음이 나오더라고요.. 쌍자음을 쉬프트+키로만 사용하고싶은데 방법이 없을까요?
translated: After trying out the default input methods and nimf, I found that the default input method, fcitx, is the most stable, so I'm sticking with it. However, one thing that bothers me is the double consonants. When I press the same key twice, it produces a double consonant. I'd like to use double consonants only with Shift+key. Is there a way to do that?

http://linuxmint.kr/System/13169

What Other keyboards do

@scarf005 scarf005 changed the title option to disable typing consonant becoming double consonant option to disable typing consonant twice making it double consonant Sep 9, 2024
@wengxt
Copy link
Member

wengxt commented Sep 9, 2024

do you mean ibus hangul has such an option or behave like that? I cant find or make ibus-hangul to work the way like you said.

@wengxt
Copy link
Member

wengxt commented Sep 9, 2024

btw if you want a easy way to type ㄱㄱ , just press esc in the middle, if that helps.

@scarf005
Copy link
Author

scarf005 commented Sep 9, 2024

do you mean ibus hangul has such an option or behave like that? I cant find or make ibus-hangul to work the way like you said.

it's the default behavior of ibus.

2024-09-10_07-29-29.mp4

image

btw if you want a easy way to type ㄱㄱ , just press esc in the middle, if that helps.

this requires extra keystroke, which is inconvenient as it deviates from other popular korean input methods.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

I'm testing with ibus-hangul 1.5.5 on archlinux and it has the exact same behavior like fcitx. What's your version of ibus-hangul?

2024-09-09.17-59-56.mp4

I think it's more likely you hit a ibus bug/issue. Instead of ibus is expected to behave like this.

@scarf005
Copy link
Author

I'm testing with ibus-hangul 1.5.5 on archlinux and it has the exact same behavior like fcitx. What's your version of ibus-hangul?
2024-09-09.17-59-56.mp4

I think it's more likely you hit a ibus bug/issue. Instead of ibus is expected to behave like this.

my ibus version is 1.5.28.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

ibus version doesnt matter. Can you do the test under X11 instead of wayland?

@scarf005
Copy link
Author

scarf005 commented Sep 10, 2024

ibus version doesnt matter.

why does ibus-hangul version matter but ibus version doesn't?

What's your version of ibus-hangul?

my ibus-hangul version is 1.5.4-2.

Can you do the test under X11 instead of wayland?

sorry but i don't follow, why does it have to be reproduced in X11 specifically?

furthermore, ibus behavior was just one of the many examples given, and talking about this further seems to stray from original topic of feature request.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

@scarf005 you didnt get what I mean.

So first of all, I believe you wrongly think that ibus has this feature. I think the behavior you saw is actually a bug when you use ibus-hangul and wayland.

To my knowledge, the ibus that you're using have no proper wayland support.

ibus-hangul code havent got any code change in recent years. that's why I'm confused why you claim ibus does this and I can not get the same behavior here on my system.

Don't get me wrong, fcitx hangul support was initially ported from ibus implementation. The thing is I dont understand why same code would have different behavior.

If you can prove that ibus-hangul can do the behavior you said under X11, then I'd be happy to check how they implemented this.

Or you can leave the distribution name and I can test it myself. Is that a kubuntu or kde neon or just debian?

@scarf005
Copy link
Author

scarf005 commented Sep 10, 2024

2024-09-10_23-16-18.mp4

recorded in X11 ibus-hangul. not sure why this works on my machine. there's also this open issue: libhangul/ibus-hangul#111

it should be also noted that ibus also suffers for ㄱ + ㅅ -> ㄳ; ㄱㅅ is often used term for 'thanks' so is not desirable.

If you can prove that ibus-hangul can do the behavior you said under X11, then I'd be happy to check how they implemented this.

the reference code for ㄱ + ㄱ -> ㄱㄱ rules can be found here: libhangul/libhangul@1b438ae

system information of laptop with ibus:

OS: Kubuntu 23.04 x86_64 
kde plasma: 5.27.4
platform: X11
Kernel: 6.3.1-060301-generic
ibus: 1.5.28-3
ibus-hangul: 1.5.4-2

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

what's your distribution? It might carry some patch in the downstream.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

@wengxt I can see debian packaged a git 2019 version of libhangul, that might be the reason.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

@scarf005 actually.. when I install hangul git version here, I automatically get the behavior you asked, without any code change on fcitx5-hangul.

@scarf005
Copy link
Author

what's your distribution? It might carry some patch in the downstream.

have you read #12 (comment) ? it's kubuntu 23.04

@scarf005
Copy link
Author

scarf005 commented Sep 10, 2024

@scarf005 actually.. when I install hangul git version here, I automatically get the behavior you asked, without any code change on fcitx5-hangul.

that's a good news... i guess it means fcitx-hangul depends on dynamically linked libhangul? but it would be even better to have an option for it.

it should be also noted that ibus also suffers for ㄱ + ㅅ -> ㄳ; ㄱㅅ is often used term for 'thanks' so is not desirable.

furthermore, it only works on 된소리(ㅃ,ㅉ,ㄸ,ㄲ,ㅆ), not cases such as ㄱ + ㅅ -> ㄳ. it would be great to have an option to disable this behavior too.

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

@scarf005 Sorry I missed that information. But actually I think since libhangul is updated, it doesn't need fcitx code change to have this feature since option_combi_on_double_stroke is false by default.

can you check if fcitx5-hangul work the same way like ibus-hangul on your kubuntu 23.04 system?

@wengxt
Copy link
Member

wengxt commented Sep 10, 2024

furthermore, it only works on 된소리(ㅃ,ㅉ,ㄸ,ㄲ,ㅆ), not cases such as ㄱ + ㅅ -> ㄳ. it would be great to have an option to disable this behavior too.

libhangul/libhangul@bf49813

Is this the option you're looking for? ^

I asked them to create a release. I dont feel comfortable to have code against unstable/unreleased api.

libhangul/libhangul#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants