From fe7eb6ae4ba9b18f956e4d768d3dd607593b7077 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 00:09:24 +0200
Subject: [PATCH 1/6] chore

---
 src/components/Settings/SoftwareUpgradeSettings.vue | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/components/Settings/SoftwareUpgradeSettings.vue b/src/components/Settings/SoftwareUpgradeSettings.vue
index 41f390b1..43379706 100644
--- a/src/components/Settings/SoftwareUpgradeSettings.vue
+++ b/src/components/Settings/SoftwareUpgradeSettings.vue
@@ -81,8 +81,7 @@
               :disabled="isDisabledRelease(release)"
               :label="calculateLabelDisabledReason(release)"
               :value="release.tag_name"
-            >
-            </v-radio>
+            />
           </v-radio-group>
           <div>
             <v-alert v-if="showPrereleases" color="primary" max-width="500px">

From 73188bf5bccf1e9bba8b314e0346b9e33c103549 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 15:08:27 +0200
Subject: [PATCH 2/6] fix: setup based printer create or update dialog with
 first short attempt at printer validation

---
 .../Dialogs/AddOrUpdatePrinterDialog.vue      | 322 +++++++-----------
 1 file changed, 129 insertions(+), 193 deletions(-)

diff --git a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
index 37e2bf7c..a3b2abe6 100644
--- a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
+++ b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
@@ -4,7 +4,7 @@
     :max-width="showChecksPanel ? '900px' : '700px'"
     @escape="closeDialog()"
   >
-    <validation-observer ref="validationObserver" v-slot="{ invalid }">
+    <ValidationObserver ref="validationObserver" v-slot="{ invalid }">
       <v-card class="pa-4">
         <v-card-title>
           <span class="text-h5">
@@ -20,7 +20,7 @@
             <v-col :cols="showChecksPanel ? 8 : 12">
               <v-row v-if="formData">
                 <v-col>
-                  <validation-provider v-slot="{ errors }" :rules="printerNameRules" name="Name">
+                  <ValidationProvider v-slot="{ errors }" :rules="printerNameRules" name="Name">
                     <v-text-field
                       v-model="formData.name"
                       :counter="printerNameRules.max"
@@ -30,10 +30,10 @@
                       label="Printer name*"
                       required
                     />
-                  </validation-provider>
+                  </ValidationProvider>
                 </v-col>
                 <v-col>
-                  <validation-provider v-slot="{ errors }" name="Enabled">
+                  <ValidationProvider v-slot="{ errors }" name="Enabled">
                     <v-checkbox
                       v-model="formData.enabled"
                       :error-messages="errors"
@@ -42,11 +42,11 @@
                       persistent-hint
                       required
                     ></v-checkbox>
-                  </validation-provider>
+                  </ValidationProvider>
                 </v-col>
               </v-row>
 
-              <validation-provider
+              <ValidationProvider
                 v-slot="{ errors }"
                 name="Printer URL"
                 persistent-hint
@@ -59,9 +59,9 @@
                   hint="F.e. 'octopi.local' or 'https://my.printer.com'"
                   label="Printer URL*"
                 ></v-text-field>
-              </validation-provider>
+              </ValidationProvider>
 
-              <validation-provider
+              <ValidationProvider
                 v-slot="{ errors }"
                 :rules="apiKeyRules"
                 name="ApiKey"
@@ -77,7 +77,7 @@
                   persistent-hint
                   required
                 ></v-text-field>
-              </validation-provider>
+              </ValidationProvider>
             </v-col>
 
             <PrinterChecksPanel v-if="showChecksPanel" :cols="4">
@@ -107,12 +107,12 @@
           </v-btn>
         </v-card-actions>
       </v-card>
-    </validation-observer>
+    </ValidationObserver>
   </BaseDialog>
 </template>
 
-<script lang="ts">
-import { defineComponent, inject } from "vue";
+<script lang="ts" setup>
+import { computed, defineComponent, inject, onMounted, ref, watch } from "vue";
 import { ValidationObserver, ValidationProvider } from "vee-validate";
 import { generateInitials, newRandomNamePair } from "@/shared/noun-adjectives.data";
 import { usePrinterStore } from "@/store/printer.store";
@@ -129,189 +129,125 @@ import { useDialog } from "@/shared/dialog.composable";
 import { AppConstants } from "@/shared/app.constants";
 import { useSnackbar } from "@/shared/snackbar.composable";
 
-const watchedId = "printerId";
-
-interface Data {
-  showChecksPanel: boolean;
-  copyPasteConnectionString: string;
-  formData: PreCreatePrinter;
-}
-
-export default defineComponent({
-  name: "AddOrUpdatePrinterDialog",
-  components: {
-    ValidationProvider,
-    ValidationObserver,
-    PrinterChecksPanel,
-  },
-  setup: () => {
-    const dialog = useDialog(DialogName.AddOrUpdatePrinterDialog);
-    return {
-      printersStore: usePrinterStore(),
-      testPrinterStore: useTestPrinterStore(),
-      dialog,
-      appConstants: inject("appConstants") as AppConstants,
-      snackbar: useSnackbar(),
-    };
-  },
-  async created() {
-    if (this.printerId) {
-      const crudeData = this.printersStore.printer(this.printerId) as CreatePrinter;
-      this.formData = PrintersService.convertPrinterToCreateForm(crudeData);
-    }
-  },
-  async mounted() {},
-  props: {},
-  data: (): Data => ({
-    showChecksPanel: false,
-    copyPasteConnectionString: "",
-    formData: getDefaultCreatePrinter(),
-  }),
-  computed: {
-    printerId() {
-      return this.printersStore.updateDialogPrinter?.id;
-    },
-    storedPrinter() {
-      return this.printersStore.updateDialogPrinter;
-    },
-    validationObserver() {
-      return this.$refs.validationObserver as InstanceType<typeof ValidationObserver>;
-    },
-    isUpdating() {
-      return !!this.storedPrinter;
-    },
-    submitButtonText() {
-      return this.isUpdating ? "Save" : "Create";
-    },
-    isPasteDisabled() {
-      if (!this.isClipboardApiAvailable) {
-        return !this.copyPasteConnectionString?.length;
-      }
-      return false;
-    },
-    isClipboardApiAvailable() {
-      return navigator.clipboard;
-    },
-    avatarInitials() {
-      if (this.formData) {
-        return generateInitials(this.formData?.name);
-      }
-      return "?";
-    },
-    printerNameRules() {
-      return { required: true, max: this.appConstants.maxPrinterNameLength };
-    },
-    apiKeyRules() {
-      return {
-        required: true,
-        length: this.appConstants.apiKeyLength,
-        alpha_num: true,
-      };
-    },
-  },
-  methods: {
-    resetForm() {
-      this.formData = getDefaultCreatePrinter();
-    },
-    async quickCopyConnectionString() {
-      const printer = this.storedPrinter;
-      if (!printer) return;
-      const loginDetails = await PrintersService.getPrinterLoginDetails(printer.id);
-      const connectionString = `{"printerURL": "${loginDetails.printerURL}", "apiKey": "${loginDetails.apiKey}", "name": "${printer.name}"}`;
-
-      if (!this.isClipboardApiAvailable) {
-        this.copyPasteConnectionString = connectionString;
-        return;
-      }
-
-      // Likely happens in Firefox
-      if (!navigator.clipboard) {
-        throw new Error(
-          `Clipboard API is not available. Secure context: ${window.isSecureContext}`
-        );
-      }
-      await navigator.clipboard.writeText(connectionString);
-    },
-    openTestPanel() {
-      this.showChecksPanel = true;
-    },
-    async testPrinter() {
-      if (!(await this.isValid())) return;
-      if (!this.formData) return;
-
-      this.testPrinterStore.clearEvents();
-      this.openTestPanel();
-
-      const { correlationToken } = await this.testPrinterStore.createTestPrinter(
-        this.formData as CreatePrinter
-      );
-      this.testPrinterStore.currentCorrelationToken = correlationToken;
-    },
-    async pasteFromClipboardOrField() {
-      if (!this.formData) return;
-
-      if (!this.isClipboardApiAvailable && !this.copyPasteConnectionString?.length) {
-        return;
-      }
-
-      const jsonData = this.isClipboardApiAvailable
-        ? await navigator.clipboard.readText()
-        : this.copyPasteConnectionString;
-      const printerObject = JSON.parse(jsonData);
+const dialog = useDialog(DialogName.AddOrUpdatePrinterDialog);
+const printersStore = usePrinterStore();
+const testPrinterStore = useTestPrinterStore();
+const appConstants = inject<AppConstants>("appConstants");
+const snackbar = useSnackbar();
+
+const showChecksPanel = ref(false);
+const copyPasteConnectionString = ref("");
+const formData = ref(getDefaultCreatePrinter());
+const printerId = computed(() => printersStore.updateDialogPrinter?.id);
+
+onMounted(() => {
+  if (printerId.value) {
+    const crudeData = printersStore.printer(printerId.value) as CreatePrinter;
+    formData.value = PrintersService.convertPrinterToCreateForm(crudeData);
+  }
+});
 
-      PrintersService.applyLoginDetailsPatchForm(printerObject, this.formData);
-    },
-    async isValid() {
-      return await this.validationObserver.validate();
-    },
-    async createPrinter(newPrinterData: CreatePrinter) {
-      await this.printersStore.createPrinter(newPrinterData);
-      this.snackbar.openInfoMessage({
-        title: `Printer ${newPrinterData.name} created`,
-      });
-    },
-    async updatePrinter(updatedPrinter: CreatePrinter) {
-      const printerId = updatedPrinter.id;
+watch(printerId, (val) => {
+  if (!val) return;
+  const printer = printersStore.printer(val) as CreatePrinter;
+  formData.value = PrintersService.convertPrinterToCreateForm(printer);
+});
 
-      await this.printersStore.updatePrinter({
-        printerId: printerId as string,
-        updatedPrinter,
-      });
+const storedPrinter = computed(() => printersStore.updateDialogPrinter);
+const validationObserver = ref(null);
+const isUpdating = computed(() => !!storedPrinter.value);
+const submitButtonText = computed(() => (isUpdating.value ? "Save" : "Create"));
 
-      this.snackbar.openInfoMessage({
-        title: `Printer ${updatedPrinter.name} updated`,
-      });
-    },
-    async submit() {
-      if (!(await this.isValid())) return;
-      if (!this.formData) return;
-      const createPrinter = this.formData as CreatePrinter;
-      if (this.isUpdating) {
-        await this.updatePrinter(createPrinter);
-      } else {
-        await this.createPrinter(createPrinter);
-      }
-      this.closeDialog();
-    },
-    async duplicatePrinter() {
-      this.formData.name = newRandomNamePair();
-      this.printersStore.updateDialogPrinter = undefined;
-    },
-    closeDialog() {
-      this.dialog.closeDialog();
-      this.showChecksPanel = false;
-      this.testPrinterStore.clearEvents();
-      this.resetForm();
-      this.printersStore.updateDialogPrinter = undefined;
-      this.copyPasteConnectionString = "";
-    },
-  },
-  watch: {
-    [watchedId](val?: string) {
-      if (!val) return;
-      const printer = this.printersStore.printer(val) as CreatePrinter;
-      this.formData = PrintersService.convertPrinterToCreateForm(printer);
-    },
-  },
+const avatarInitials = computed(() => {
+  if (formData.value) {
+    return generateInitials(formData.value?.name);
+  }
+  return "?";
 });
+
+const printerNameRules = computed(() => ({
+  required: true,
+  max: appConstants!.maxPrinterNameLength,
+}));
+
+const apiKeyRules = computed(() => ({
+  required: true,
+  length: appConstants!.apiKeyLength,
+  alpha_num: true,
+}));
+
+const resetForm = () => {
+  formData.value = getDefaultCreatePrinter();
+};
+
+const openTestPanel = () => {
+  showChecksPanel.value = true;
+};
+
+const testPrinter = async () => {
+  if (!(await isValid())) return;
+  if (!formData.value) return;
+
+  testPrinterStore.clearEvents();
+  openTestPanel();
+
+  const { correlationToken } = await testPrinterStore.createTestPrinter(formData.value);
+  testPrinterStore.currentCorrelationToken = correlationToken;
+};
+
+const isValid = async () => {
+  return await validationObserver.value?.validate();
+};
+
+const createPrinter = async (newPrinterData) => {
+  await printersStore.createPrinter(newPrinterData);
+  snackbar.openInfoMessage({
+    title: `Printer ${newPrinterData.name} created`,
+  });
+};
+
+const updatePrinter = async (updatedPrinter) => {
+  const printerId = updatedPrinter.id;
+
+  await printersStore.updatePrinter({
+    printerId: printerId as string,
+    updatedPrinter,
+  });
+
+  snackbar.openInfoMessage({
+    title: `Printer ${updatedPrinter.name} updated`,
+  });
+};
+
+const submit = async () => {
+  if (!(await isValid())) return;
+  if (!formData.value) return;
+  const createdPrinter = formData.value;
+
+  try {
+    if (isUpdating.value) {
+      await updatePrinter(createdPrinter);
+    } else {
+      await createPrinter(createdPrinter);
+    }
+    closeDialog();
+  } catch (error) {
+    // handle error
+    snackbar.error("Error", error.message);
+  }
+};
+
+const duplicatePrinter = () => {
+  formData.value.name = newRandomNamePair();
+  printersStore.updateDialogPrinter = undefined;
+};
+
+const closeDialog = () => {
+  dialog.closeDialog();
+  showChecksPanel.value = false;
+  testPrinterStore.clearEvents();
+  resetForm();
+  printersStore.updateDialogPrinter = undefined;
+  copyPasteConnectionString.value = "";
+};
 </script>

From f0564e09822d390ecbd534e62c475c1f6c677f21 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 18:05:57 +0200
Subject: [PATCH 3/6] fix: add force save to printer, escape 424 in handler,
 add feedback saving

---
 src/backend/printers.service.ts               | 10 ++--
 .../Dialogs/AddOrUpdatePrinterDialog.vue      | 56 ++++++++++++++-----
 src/shared/http-client.ts                     |  5 ++
 src/store/printer.store.ts                    | 23 ++++----
 4 files changed, 65 insertions(+), 29 deletions(-)

diff --git a/src/backend/printers.service.ts b/src/backend/printers.service.ts
index 59cd17d2..0e8fbea7 100644
--- a/src/backend/printers.service.ts
+++ b/src/backend/printers.service.ts
@@ -85,8 +85,8 @@ export class PrintersService extends BaseService {
     return await this.postApi(path, axes);
   }
 
-  static async createPrinter(printer: CreatePrinter) {
-    const path = ServerApi.printerRoute;
+  static async createPrinter(printer: CreatePrinter, forceSave: boolean) {
+    const path = `${ServerApi.printerRoute}?forceSave=${forceSave}`;
 
     return (await this.postApi(path, printer)) as PrinterDto;
   }
@@ -103,10 +103,10 @@ export class PrintersService extends BaseService {
     return await this.deleteApi(path);
   }
 
-  static async updatePrinter(printerId: IdType, printer: CreatePrinter) {
+  static async updatePrinter(printerId: IdType, printer: CreatePrinter, forceSave: boolean) {
     const path = ServerApi.getPrinterRoute(printerId);
-
-    return (await this.patchApi(path, printer)) as PrinterDto;
+    const fullPath = `${path}?forceSave=${forceSave}`;
+    return (await this.patchApi(fullPath, printer)) as PrinterDto;
   }
 
   static async updatePrinterMaintenance(printerId: IdType, disabledReason: string | null = null) {
diff --git a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
index a3b2abe6..78ae6606 100644
--- a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
+++ b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
@@ -84,6 +84,14 @@
               <v-btn @click="showChecksPanel = false">Hide checks</v-btn>
             </PrinterChecksPanel>
           </v-row>
+          <v-alert color="primary" class="my-3" v-if="printerValidationError?.length">
+            {{ printerValidationError }}
+            <v-checkbox color="warning" v-model="forceSavePrinter" label="Force save" />
+          </v-alert>
+          <v-alert class="my-3" v-if="validatingPrinter">
+            Validating printer
+            <v-progress-circular indeterminate />
+          </v-alert>
         </v-card-text>
         <v-card-actions>
           <em class="red--text">* indicates required field</em>
@@ -112,7 +120,7 @@
 </template>
 
 <script lang="ts" setup>
-import { computed, defineComponent, inject, onMounted, ref, watch } from "vue";
+import { computed, inject, onMounted, ref, watch } from "vue";
 import { ValidationObserver, ValidationProvider } from "vee-validate";
 import { generateInitials, newRandomNamePair } from "@/shared/noun-adjectives.data";
 import { usePrinterStore } from "@/store/printer.store";
@@ -123,11 +131,11 @@ import { useTestPrinterStore } from "@/store/test-printer.store";
 import {
   CreatePrinter,
   getDefaultCreatePrinter,
-  PreCreatePrinter,
 } from "@/models/printers/crud/create-printer.model";
 import { useDialog } from "@/shared/dialog.composable";
 import { AppConstants } from "@/shared/app.constants";
 import { useSnackbar } from "@/shared/snackbar.composable";
+import { AxiosError } from "axios";
 
 const dialog = useDialog(DialogName.AddOrUpdatePrinterDialog);
 const printersStore = usePrinterStore();
@@ -135,6 +143,9 @@ const testPrinterStore = useTestPrinterStore();
 const appConstants = inject<AppConstants>("appConstants");
 const snackbar = useSnackbar();
 
+const printerValidationError = ref<null | string>(null);
+const validatingPrinter = ref(false);
+const forceSavePrinter = ref(false);
 const showChecksPanel = ref(false);
 const copyPasteConnectionString = ref("");
 const formData = ref(getDefaultCreatePrinter());
@@ -156,7 +167,9 @@ watch(printerId, (val) => {
 const storedPrinter = computed(() => printersStore.updateDialogPrinter);
 const validationObserver = ref(null);
 const isUpdating = computed(() => !!storedPrinter.value);
-const submitButtonText = computed(() => (isUpdating.value ? "Save" : "Create"));
+const submitButtonText = computed(
+  () => (forceSavePrinter.value ? "Force " : "") + (isUpdating.value ? "Save" : "Create")
+);
 
 const avatarInitials = computed(() => {
   if (formData.value) {
@@ -201,18 +214,24 @@ const isValid = async () => {
 
 const createPrinter = async (newPrinterData) => {
   await printersStore.createPrinter(newPrinterData);
-  snackbar.openInfoMessage({
-    title: `Printer ${newPrinterData.name} created`,
-  });
+  snackbar.openInfoMessage(
+    {
+      title: `Printer ${newPrinterData.name} created`,
+    },
+    forceSavePrinter.value
+  );
 };
 
 const updatePrinter = async (updatedPrinter) => {
   const printerId = updatedPrinter.id;
 
-  await printersStore.updatePrinter({
-    printerId: printerId as string,
-    updatedPrinter,
-  });
+  await printersStore.updatePrinter(
+    {
+      printerId: printerId as string,
+      updatedPrinter,
+    },
+    forceSavePrinter.value
+  );
 
   snackbar.openInfoMessage({
     title: `Printer ${updatedPrinter.name} updated`,
@@ -220,8 +239,10 @@ const updatePrinter = async (updatedPrinter) => {
 };
 
 const submit = async () => {
-  if (!(await isValid())) return;
-  if (!formData.value) return;
+  if (!formData.value || !(await isValid())) return;
+
+  printerValidationError.value = null;
+  validatingPrinter.value = true;
   const createdPrinter = formData.value;
 
   try {
@@ -232,8 +253,15 @@ const submit = async () => {
     }
     closeDialog();
   } catch (error) {
-    // handle error
-    snackbar.error("Error", error.message);
+    if (error instanceof AxiosError) {
+      printerValidationError.value = error.response?.data?.error || error.message;
+      snackbar.error("Validation Failed", (error as Error).message);
+    } else {
+      printerValidationError.value = (error as Error).message;
+      snackbar.error("Error", (error as Error).message);
+    }
+  } finally {
+    validatingPrinter.value = false;
   }
 };
 
diff --git a/src/shared/http-client.ts b/src/shared/http-client.ts
index bd27c4a5..f4ff5e88 100644
--- a/src/shared/http-client.ts
+++ b/src/shared/http-client.ts
@@ -62,6 +62,11 @@ export async function getHttpClient(withAuth: boolean = true, autoHandle401: boo
         });
       }
 
+      // Special code
+      if (response.status === HttpStatusCode.FailedDependency) {
+        return Promise.reject(error);
+      }
+
       if (![HttpStatusCode.Unauthorized, HttpStatusCode.Forbidden].includes(response.status)) {
         // Timeout issues etc?
         console.error("Error in axios response interceptor which is not 401 or 403", error);
diff --git a/src/store/printer.store.ts b/src/store/printer.store.ts
index 23bf61aa..a4e7a45c 100644
--- a/src/store/printer.store.ts
+++ b/src/store/printer.store.ts
@@ -59,8 +59,8 @@ export const usePrinterStore = defineStore("Printers", {
     },
   },
   actions: {
-    async createPrinter(newPrinter: CreatePrinter) {
-      const data = await PrintersService.createPrinter(newPrinter);
+    async createPrinter(newPrinter: CreatePrinter, forceSave: boolean) {
+      const data = await PrintersService.createPrinter(newPrinter, forceSave);
       this.printers.push(data);
       this.printers.sort((a: PrinterDto, b: PrinterDto) =>
         a.name?.toLowerCase()?.localeCompare(b?.name?.toLowerCase()) ? 1 : -1
@@ -90,14 +90,17 @@ export const usePrinterStore = defineStore("Printers", {
     setMaintenanceDialogPrinter(printer?: PrinterDto) {
       this.maintenanceDialogPrinter = printer;
     },
-    async updatePrinter({
-      printerId,
-      updatedPrinter,
-    }: {
-      printerId: IdType;
-      updatedPrinter: CreatePrinter;
-    }) {
-      const data = await PrintersService.updatePrinter(printerId, updatedPrinter);
+    async updatePrinter(
+      {
+        printerId,
+        updatedPrinter,
+      }: {
+        printerId: IdType;
+        updatedPrinter: CreatePrinter;
+      },
+      forceSave: boolean
+    ) {
+      const data = await PrintersService.updatePrinter(printerId, updatedPrinter, forceSave);
       this._replacePrinter({ printerId, printer: data });
       return data;
     },

From f31d3a049bf4df272039a0297e2b5606e8119387 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 18:17:40 +0200
Subject: [PATCH 4/6] fix: wrong passing of forceSave property

---
 .../Dialogs/AddOrUpdatePrinterDialog.vue      | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
index 78ae6606..1c2a0958 100644
--- a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
+++ b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
@@ -149,6 +149,7 @@ const forceSavePrinter = ref(false);
 const showChecksPanel = ref(false);
 const copyPasteConnectionString = ref("");
 const formData = ref(getDefaultCreatePrinter());
+
 const printerId = computed(() => printersStore.updateDialogPrinter?.id);
 
 onMounted(() => {
@@ -204,7 +205,9 @@ const testPrinter = async () => {
   testPrinterStore.clearEvents();
   openTestPanel();
 
-  const { correlationToken } = await testPrinterStore.createTestPrinter(formData.value);
+  const { correlationToken } = await testPrinterStore.createTestPrinter(
+    formData.value as CreatePrinter
+  );
   testPrinterStore.currentCorrelationToken = correlationToken;
 };
 
@@ -212,17 +215,14 @@ const isValid = async () => {
   return await validationObserver.value?.validate();
 };
 
-const createPrinter = async (newPrinterData) => {
-  await printersStore.createPrinter(newPrinterData);
-  snackbar.openInfoMessage(
-    {
-      title: `Printer ${newPrinterData.name} created`,
-    },
-    forceSavePrinter.value
-  );
+const createPrinter = async (newPrinterData: CreatePrinter) => {
+  await printersStore.createPrinter(newPrinterData, forceSavePrinter.value);
+  snackbar.openInfoMessage({
+    title: `Printer ${newPrinterData.name} created`,
+  });
 };
 
-const updatePrinter = async (updatedPrinter) => {
+const updatePrinter = async (updatedPrinter: CreatePrinter) => {
   const printerId = updatedPrinter.id;
 
   await printersStore.updatePrinter(

From 382eaafbbce58a0baa029821e0042b4644f95980 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 18:25:22 +0200
Subject: [PATCH 5/6] fix: reset force save and error after submit or dialog
 close

---
 src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
index 1c2a0958..b198e92e 100644
--- a/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
+++ b/src/components/Generic/Dialogs/AddOrUpdatePrinterDialog.vue
@@ -262,16 +262,22 @@ const submit = async () => {
     }
   } finally {
     validatingPrinter.value = false;
+    forceSavePrinter.value = false;
   }
 };
 
 const duplicatePrinter = () => {
   formData.value.name = newRandomNamePair();
   printersStore.updateDialogPrinter = undefined;
+  printerValidationError.value = null;
+  forceSavePrinter.value = false;
+  printerValidationError.value = null;
 };
 
 const closeDialog = () => {
   dialog.closeDialog();
+  forceSavePrinter.value = false;
+  printerValidationError.value = null;
   showChecksPanel.value = false;
   testPrinterStore.clearEvents();
   resetForm();

From 16fcf3330905a7af9ebbfdbd1998d813c469eaf7 Mon Sep 17 00:00:00 2001
From: David Zwart <david@visionintellilgence.ai>
Date: Fri, 19 Apr 2024 18:28:56 +0200
Subject: [PATCH 6/6] release: 1.5.13 with release note

---
 RELEASE_NOTES.MD | 6 ++++++
 package.json     | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/RELEASE_NOTES.MD b/RELEASE_NOTES.MD
index cc5e779f..f483cf8b 100644
--- a/RELEASE_NOTES.MD
+++ b/RELEASE_NOTES.MD
@@ -1,5 +1,11 @@
 # Client develop
 
+# Client 18/04/2024 1.5.13
+
+Features:
+
+- Printer Create/Update: add URL and apiKey validation with feedback. When wanted force save can be used in case of failures.
+
 # Client 18/04/2024 1.5.12
 
 Fixes:
diff --git a/package.json b/package.json
index e8c73c1d..1e73d978 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@fdm-monster/client",
-  "version": "1.5.12",
+  "version": "1.5.13",
   "author": "David Zwart",
   "license": "AGPL-3.0-or-later",
   "repository": {