Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery policy tags for offline store #5064

Open
danbaron63 opened this issue Feb 17, 2025 · 1 comment
Open

BigQuery policy tags for offline store #5064

danbaron63 opened this issue Feb 17, 2025 · 1 comment
Labels
kind/feature New feature or request

Comments

@danbaron63
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When using Feast data sources we can either allow Feast to create the BigQuery table in BigQuery or we can pre-create it and have Feast write to it. In our org having feast create the table is not allowed due to policy tags which are used to control column access in BigQuery.

Describe the solution you'd like
The BigQuery data source could support policy tagging such that column level tags could be added in code and be applied to the table columns when Feast creates the table.

Describe alternatives you've considered
We currently set table_create_disposition: CREATE_NEVER and pre-create tables ourselves with appropriate tagging. This adds additional steps to the deployment process making it error prone.

Additional context
BigQuery policy tags

@danbaron63 danbaron63 added the kind/feature New feature or request label Feb 17, 2025
@franciscojavierarceo
Copy link
Member

@danbaron63 this sounds like a good idea. Have you seen our permissions documentation?

We could probably take some inspiration from there.

Here's an example:

# Permissions on a Feature View
Permission(
    name="feature-reader",
    types=[FeatureView, FeatureService],
    policy=RoleBasedPolicy(roles=["super-reader"]),
    actions=[AuthzedAction.DESCRIBE, *READ],
)
# Permissions on a Data Source
Permission(
    name="ds-writer",
    types=[DataSource],
    required_tags={"risk_level": "high"},
    policy=RoleBasedPolicy(roles=["admin", "data_team"]),
    actions=[AuthzedAction.WRITE],
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants