Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

type: ASTNode types have incorrect optional properties #63

Open
yxliang01 opened this issue May 7, 2019 · 2 comments
Open

type: ASTNode types have incorrect optional properties #63

yxliang01 opened this issue May 7, 2019 · 2 comments

Comments

@yxliang01
Copy link
Contributor

There are some properties of ASTNode types declared as optional via adding ? to ``PROPERTY_NAME (PROPERTY_NAME?`). However, marking optional in this way results in saying such property having value `TYPE | undefined | null` while they are in fact of type `TYPE | null` (or correct me if wrong). e.g.

storageLocation?: string;

CC: @Leeleo3x

@aoli-al
Copy link
Contributor

aoli-al commented May 10, 2019

It is true. Will this introduce any side effect?

@yxliang01
Copy link
Contributor Author

I see. Side effect as in? @Leeleo3x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants