wip: PCV v3 #855
Closed
wip: PCV v3 #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eswak
commented
Jun 15, 2022
|
|
||
| /// @notice convert an amount of assets | ||
| /// All numbers must be in the order returned by assets(). | ||
| function convertAssets(int256[] memory amountsIn, int256[] memory minAmountsOut) |
eswak
commented
Jun 15, 2022
|
|
||
| /// @notice list of assets handled by this strategy | ||
| /// asset() must be a assets()[0] | ||
| function assets() public view virtual returns (address[] memory tokens) { |
There was a problem hiding this comment.
separate 4626 strategies & multi assets strategies
eswak
commented
Jun 15, 2022
| /// in that case, all external calls happen through the Safe, and | ||
| /// the Safe will hold all ERC4626 vault shares, as well as all | ||
| /// tokens used in conversions. | ||
| address public gnosisSafeAddress; |
There was a problem hiding this comment.
make an opinionated choice : either it's through a gnosis safe or not
eswak
commented
Jun 15, 2022
Comment on lines
+22
to
+30
| event SetOracle(address caller, address indexed token, address indexed oracle); | ||
| event AssetRegister(address caller, address indexed token); | ||
| event AssetDeregister(address caller, address indexed token); | ||
| event StrategyRegister(address caller, address indexed strategy); | ||
| event StrategyDeregister(address caller, address indexed strategy); | ||
| event Balance(address caller, address indexed token, uint256 amount); | ||
| event Deploy(address caller, address indexed strategy, address indexed token, uint256 amount); | ||
| event Recall(address caller, address indexed strategy, address indexed token, uint256 amount); | ||
| event Revenue(address caller, address indexed strategy, address indexed token, int256 amount); |
There was a problem hiding this comment.
make a spec of transitions in the vault & access control etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.