Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving setup.cfg and setup.py to pyproject.toml #877

Merged

Conversation

shimwell
Copy link
Contributor

Proposed changes

We could move the setup.cfg and setup.py to the more modern pyproject.toml

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

pyproject.toml is now recommend method of python packaging
https://packaging.python.org/en/latest/tutorials/packaging-projects/

@shimwell
Copy link
Contributor Author

shimwell commented Aug 15, 2024

the linter is complaining about a file not changing in this PR
/home/runner/work/FESTIM/FESTIM/festim/boundary_conditions/fluxes/surface_kinetics.py

@shimwell
Copy link
Contributor Author

I added the missing comma to the file so it should be happy now

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (c8a0c66) to head (68bc0a2).
Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          61       61           
  Lines        2750     2750           
=======================================
  Hits         2738     2738           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon for always keeping us up to date! I'll leave this open for a little while to see if someone else has anything to say.

I tested it locally and was able to pip install the code! ✅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, weird that this wasn't caught before.

@RemDelaporteMathurin RemDelaporteMathurin added the Distribution Docker, pip, ... label Aug 16, 2024
@RemDelaporteMathurin RemDelaporteMathurin merged commit abe3942 into festim-dev:main Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Distribution Docker, pip, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants