Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for interface discontinuities #944

Draft
wants to merge 10 commits into
base: fenicsx
Choose a base branch
from
Draft

Refactoring for interface discontinuities #944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dd9e997
everything in the same file
RemDelaporteMathurin Feb 18, 2025
150f878
consistent naming
RemDelaporteMathurin Feb 18, 2025
0731b95
consistent naming 2
RemDelaporteMathurin Feb 18, 2025
280eeb0
merged classes
RemDelaporteMathurin Feb 18, 2025
8b6a6bb
default value
RemDelaporteMathurin Feb 18, 2025
c2516b1
penalty default
RemDelaporteMathurin Feb 18, 2025
d14e191
removed special class for species
RemDelaporteMathurin Feb 18, 2025
74f911d
add default PETSc options and refactor petsc_options handling
RemDelaporteMathurin Feb 18, 2025
65a973b
removed some duplicated code
RemDelaporteMathurin Feb 18, 2025
a23d5e6
remove dead code
RemDelaporteMathurin Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/multi_material_1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import festim as F

my_model = F.HTransportProblemDiscontinuous()
my_model = F.HydrogenTransportProblemDiscontinuous()
my_model.method_interface = "nietsche"

interface_1 = 0.5
interface_2 = 0.7
Expand Down
3 changes: 2 additions & 1 deletion examples/multi_material_2d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def half(x):

mesh, mt, ct = generate_mesh()

my_model = F.HTransportProblemDiscontinuous()
my_model = F.HydrogenTransportProblemDiscontinuous()
my_model.method_interface = "nietsche"
my_model.mesh = F.Mesh(mesh)
my_model.volume_meshtags = ct
my_model.facet_meshtags = mt
Expand Down
3 changes: 2 additions & 1 deletion examples/multi_material_2d_bis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ def half(x):

mesh, mt, ct = generate_mesh()

my_model = F.HTransportProblemDiscontinuous()
my_model = F.HydrogenTransportProblemDiscontinuous()
my_model.method_interface = "nietsche"
my_model.mesh = F.Mesh(mesh)
my_model.volume_meshtags = ct
my_model.facet_meshtags = mt
Expand Down
3 changes: 2 additions & 1 deletion examples/multi_material_transient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import festim as F

my_model = F.HTransportProblemDiscontinuous()
my_model = F.HydrogenTransportProblemDiscontinuous()
my_model.method_interface = "nietsche"

interface_1 = 0.5
interface_2 = 0.7
Expand Down
4 changes: 2 additions & 2 deletions examples/multi_material_with_one_material.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

import festim as F

my_model = F.HTransportProblemDiscontinuous()

my_model = F.HydrogenTransportProblemDiscontinuous()
my_model.method_interface = "nietsche"

N = 1500
vertices = np.linspace(0, 1, num=N)
Expand Down
7 changes: 3 additions & 4 deletions src/festim/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@
from .heat_transfer_problem import HeatTransferProblem
from .helpers import as_fenics_constant
from .hydrogen_transport_problem import (
HTransportProblemDiscontinuous,
HydrogenTransportProblemDiscontinuous,
HydrogenTransportProblem,
HTransportProblemPenalty,
HydrogenTransportProblemDiscontinuousChangeVar,
)
from .problem_change_of_var import HydrogenTransportProblemDiscontinuousChangeVar
from .initial_condition import InitialCondition, InitialTemperature
from .material import Material
from .mesh.mesh import Mesh
Expand All @@ -52,7 +51,7 @@
from .reaction import Reaction
from .settings import Settings
from .source import HeatSource, ParticleSource, SourceBase
from .species import ImplicitSpecies, Species, find_species_from_name, SpeciesChangeVar
from .species import ImplicitSpecies, Species, find_species_from_name
from .stepsize import Stepsize
from .subdomain.interface import Interface
from .subdomain.surface_subdomain import SurfaceSubdomain, find_surface_from_id
Expand Down
Loading
Loading