Export average surface temperature #949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #949 +/- ##
===========================================
- Coverage 96.02% 95.89% -0.13%
===========================================
Files 45 46 +1
Lines 2439 2511 +72
===========================================
+ Hits 2342 2408 +66
- Misses 97 103 +6 ☔ View full report in Codecov by Sentry. |
RemDelaporteMathurin
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Hi @kaelyndunnell thanks for this, this is very much needed!
However I think it should be implemented differently:
- It doesn't make sense to ask users to provide
temperature_fieldas an argument ofSurfaceTemperaturesince they don't have access to the fenics object (fem.Constantorfem.Temperature) before callinginitialiseand since exports are defined before callinginitialise. Instead, I believe the class should not have this argument at all, andtemperature_fieldis set as an attribute only insideHTransportProblem
for export in self.exports:
if isinstance(export, SurfaceTemperature):
export.temperature_field = self.temperature_fenicsSurfaceTemperatureshares a lot of functionality withSurfaceQuantity: it should inherit from it- I'm thinking by looking at this we should revisit the design of these quantities @JonathanGSDUFOUR , I'll open an issue to describe my idea but here's the rough pitch
class SurfaceQuantity:
def __init__(self, surface, filename):
self.surface = surface
self.filename = filename
self.field = None # this is no longer a user argument but only an attribute
...
class AverageSurfaceConcentration(SurfaceQuantity):
def __init__(self, species, surface, filename):
self.species = species
super.__init__(surface, filename)Inside HTransportProblem
def initialise_exports(self):
for export in self.exports:
if not hasattr(export, "species"): # appropriate fenics functions are already stored in F.Species objects
export.field = self.temperature_fenics | import ufl | ||
| import festim as F | ||
|
|
||
| class SurfaceTemperature: |
There was a problem hiding this comment.
I would be explicit an name it AverageSurfaceTemperature
There was a problem hiding this comment.
This should inherit from SurfaceQuantity
Suggested change
| class SurfaceTemperature: | |
| class SurfaceTemperature(F.SurfaceQuantity): |
Comment on lines
+45
to
+53
| @property | ||
| def surface(self): | ||
| return self._surface | ||
|
|
||
| @surface.setter | ||
| def surface(self, value): | ||
| if not isinstance(value, (int, F.SurfaceSubdomain)) or isinstance(value, bool): | ||
| raise TypeError("surface should be an int or F.SurfaceSubdomain") | ||
| self._surface = value |
There was a problem hiding this comment.
This is duplicated from SurfaceQuantity. Can be removed when this class inherits from it
Comment on lines
+31
to
+43
| @property | ||
| def filename(self): | ||
| return self._filename | ||
|
|
||
| @filename.setter | ||
| def filename(self, value): | ||
| if value is None: | ||
| self._filename = None | ||
| elif not isinstance(value, str): | ||
| raise TypeError("filename must be of type str") | ||
| elif not value.endswith(".csv") and not value.endswith(".txt"): | ||
| raise ValueError("filename must end with .csv or .txt") | ||
| self._filename = value |
There was a problem hiding this comment.
Can be removed if inherits from SurfaceQuantity
Comment on lines
+87
to
+102
| def write(self, t): | ||
| """Writes the time and temperature value to the file. | ||
|
|
||
| Args: | ||
| t (float): current time value | ||
| """ | ||
| if self.filename is not None: | ||
| if self._first_time_export: | ||
| header = ["t(s)", f"{self.title}"] | ||
| with open(self.filename, mode="w+", newline="") as file: | ||
| writer = csv.writer(file) | ||
| writer.writerow(header) | ||
| self._first_time_export = False | ||
| with open(self.filename, mode="a", newline="") as file: | ||
| writer = csv.writer(file) | ||
| writer.writerow([t, self.value]) |
There was a problem hiding this comment.
Can be removed if inherits from SurfaceQuantity
| @@ -786,6 +793,8 @@ def update_time_dependent_values(self): | |||
| if source.temperature_dependent: | |||
| source.update(t=t) | |||
|
|
|||
| surface_temp_processed = False | |||
There was a problem hiding this comment.
What is this? the indentation is odd, is this a leftover?
Comment on lines
+831
to
+838
| elif isinstance(export, exports.SurfaceTemperature): | ||
| export.compute(self.ds) # compute surface temp | ||
|
|
||
| export.t.append(float(self.t)) # update export time | ||
|
|
||
| # if filename given write export data to file | ||
| if export.filename is not None: | ||
| export.write(t=float(self.t)) |
There was a problem hiding this comment.
These lines are not tested. That's because by design, it's impossible to use SurfaceTemperature in combination with HTransportProblem
RemDelaporteMathurin
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds export for average surface temperature.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...