Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using another comparison method for integral numbers #20

Open
jaebradley opened this issue Mar 15, 2023 · 0 comments
Open

Using another comparison method for integral numbers #20

jaebradley opened this issue Mar 15, 2023 · 0 comments

Comments

@jaebradley
Copy link

jaebradley commented Mar 15, 2023 •
edited
Loading

I might have missed something, but my understanding is that the JsonNumEquals class would not view IntNode(1) and LongNode(1) as equivalent as the JsonNumEquals class delegates to each class's equals implementation when comparing IntNodes and LongNodes.

If my understanding is correct, would you consider using another comparison method for integral numbers? For example, could the bigIntegerValue() method be considered as a replacement?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaebradley