Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against hardware-wallet/skycoin-api #34

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

Run tests against hardware-wallet/skycoin-api #34

isaacvr opened this issue Oct 31, 2019 · 0 comments

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Feature description
Refactor tests

Describe the feature

It's desired to run this tests battery against hardware-wallet/skycoin-api, as hardware-wallet/skycoin-api have a subset of the libskycoin features it's required to refactor the tests to run all against libskycoin as it' currently and a test subset against hardware-wallet/skycoin-api.

Describe the solution you'd like
Just refactor tests without changing them.

Describe alternatives you've considered
Modifing the library it's not al alternative as this code is auto generated.

Additional context
https://github.com/skycoin/hardware-wallet/issues/84

Possible implementation
This is just about a refactorization, please do not change any thing
@isaacvr isaacvr mentioned this issue Oct 31, 2019
Closed
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
af6585c 
move isU8Eq from lib/cgo/tests/testutils/libsky_assert.c to lib/cgo/tests/testutils/common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
1f3d18d 
move TestAddSHA256 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
run common_check_cipher_hash in libskycoin tests after refactor ref #34
ea25ad9
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
run tests against hardware wallet ref #34
95f7f43
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
makefile rule to run hardware wallet tests ref #34
308b148
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix in test-hw-crypto makefile rule ref #34
ed4c63a
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
810c8e5 
…hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.hash.c
	lib/cgo/tests/test_main.c
	lib/cgo/tests/testutils/libsky_assert.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
disable build matrix
907ee1a 
this commit should be reverted
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
bc3c949 
move TestAddressString from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
a16a448 
move registerMemCleanup from lib/cgo/tests/testutils/libsky_testutil.c to lib/cgo/tests/testutils/common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
e6596ab 
move TestAddressBulk from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
c308812 
move TestAddressNull from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
1ff07f2 
move copyGoSlice_toGoSlice from lib/cgo/tests/testutils/libsky_testutil.c to lib/cgo/tests/testutils/common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
9a90451 
move TestAddressFromBytes from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
66fd014 
move TestDecodeBase58Address from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
finally removed lib/cgo/tests/check_cipher.address.c as all address related test can be run against hardware wallet
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
1e8eedf 
moce TestHashRipemd160 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
ffcec79 
move TestSHA256KnownValue from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
b0ae131 
move TestSumSHA256 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
e3bef74 
move TestSHA256Hex from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
00a0099 
move TestSHA256Set from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
0408866 
move TestSHA256FromHex from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
9038eeb 
move TestSHA256Null from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
recator
6dc0acc 
move TestNewPubKey from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
f1f8671 
move TestPubKeyFromHex from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
40f0c59 
move TestPubKeyHex from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
f08c9b5 
move TestPubKeyVerify from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
50eb911 
move TestPubKeyVerifyNil from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
80c1c02 
move TestPubKeyVerifyDefault1 from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor
df99fa2 
move TestPubKeyToAddress2 from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
985bfa8 
…hardware-wallet_tests

Conflicts:
	lib/cgo/tests/testutils/libsky_assert.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix bugs in tests suits ref #34
3d20e38
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
e3cb4bd 
…hardware-wallet_tests

Conflicts:
	Makefile
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
TestECDH* tests are not requiered for firmware ref #34
09abe50
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix linker flag to load shared lib ref #34
d2585f7
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
757c3de 
…hardware-wallet_tests ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
add dependencies to test-hw-crypto rule ref #34
6fc9e33
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
run hw test with valgind ref #34
8778c36
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
disable mem clean up ref #34
0b3e3f2
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
enable cleanupMem ref #34
f93a34c
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Revert "fix bugs in tests suits ref #34"
0cb4f33 
This reverts commit 3d20e38.

ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
rebuild check library only if required ref #34
fe3a69a
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix bug ref #34
d2135b8
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'simelo/v0.25dev' into stdevAlDen_t34_ha…
43a22e5 
…rdware-wallet_tests

Conflicts:
	Makefile
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'simelo/v0.25dev' into stdevAlDen_t34_ha…
dab1157 
…rdware-wallet_tests

Conflicts:
	Makefile
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
move test-hw-crypto to hardware wallet repo ref #34
8c0307d
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
install check on linux if it is not build yet ref #34
3e6f1f7
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix bugs and/or warnings ref #34
af75a4b
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix memory buffer handling in TestPubKeyHex ref #34
b5bf315
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix test assertion in TestPubKeyHex ref #34
5a7bd53
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
fix in TestAddressString ref #34
8af339a
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Fix in TestAddressBulk, initialize string memory in the test ref #34
cbcc513
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Fix buffer size in TestDecodeBase58Address ref #34
e2a5b2d
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'upstream/develop' into stdevAlDen_t34_h…
f91833c 
…ardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.address.common.c
	lib/cgo/tests/check_cipher.crypto.c
	lib/cgo/tests/check_cipher.hash.c
	lib/cgo/tests/testutils/libsky_assert.c
	lib/cgo/tests/testutils/libsky_testutil.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge branch 'stdevHan_t105_update_submodule_0.27.0' into stdevAlDen_…
8241bd4 
…t34_hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.crypto.c
	lib/cgo/tests/testutils/libsky_assert.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
remove some test from hw
bdce11a 
 - TestAddressRoundtrip
 - TestAddressString
 - TestAddressBulk
 - TestDecodeBase58Address
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
keep tests unchanged from 0.27 ref #34
175d7fa
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
Merge remote-tracking branch 'simelo/stdevHan_t105_update_submodule_0…
b432115 
….27.0' into stdevAlDen_t34_hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.address.c
	lib/cgo/tests/testutils/libsky_assert.c
	lib/cgo/tests/testutils/libsky_testutil.c
ref #34
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
refactor libsky_assert in two files ref #34
524c394
stdevMac pushed a commit that referenced this issue Nov 11, 2019
@stdevAlDen
remove TestPubKeyToAddress2 from the hw suit ref #34
b2f7e3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacvr