New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The curl library should be build in release mode for release versions #66

Open

isaacvr opened this issue Oct 31, 2019 · 0 comments

Labels

bug

isaacvr commented Oct 31, 2019

Describe the bug
The build type is hard coded.

Environment information:

Any

Steps to Reproduce
Just look at the code https://github.com/simelo/libskycoin/blob/3cb637dbd49eb3073d18b25205cc58e2519a28c7/lib/curl/CMakeLists.txt#L9

Actual behavior
The curl library is build in debug as unique option.

Expected behavior
Be able to set a predefined value via command line.

Additional context
It's very important to move on this if you regenerate the CMakeLists.txt file.

isaacvr added the bug label

isaacvr mentioned this issue

Build curl lib in release mode #67

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment