Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for constrainProportions in favor of targetAspectRatio #34

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

gh-owongfigma
Copy link
Contributor

With the release of Aspect Ratio Lock, we'll be supporting it in the plugin API via the targetAspectRatio property, set by lockAspectRatio and unlockAspectRatio. This should replace constrainProportions going forward. (The next update to the plugin API will already redirect sets of constrainProportions to modify targetAspectRatio).

Test Plan

  • Tested manually by creating a plugin repository, and seeing the ESLint warning in VSCode.
image

@gh-owongfigma gh-owongfigma marked this pull request as ready for review February 12, 2025 23:02
@jefflee-figma jefflee-figma requested review from knguyen-figma and removed request for jefflee-figma February 12, 2025 23:16
@gh-owongfigma gh-owongfigma merged commit a6b8588 into main Feb 14, 2025
1 check passed
@gh-owongfigma gh-owongfigma deleted the owong/constrain-proportions-warning branch February 14, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants