Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slashsvc): reduce block not found error logs #12907

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Feb 19, 2025

Related Issues

#12906

Proposed Changes

Reduces log level for ipld: could not find logs to DEBUG.

Checklist

Before you mark the PR ready for review, please make sure that:

fix(slashsvc): reduce `block not found` error logs
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Feb 19, 2025
fix: replace string check with ipld.IsNotFound
chore: make gen
@rvagg
Copy link
Member

rvagg commented Feb 20, 2025

Do we know why this is throwing up not found errors though? Is it reasonable behaviour?

@rjan90
Copy link
Contributor Author

rjan90 commented Feb 20, 2025

Do we know why this is throwing up not found errors though? Is it reasonable behaviour?

My hunch is that this is somewhat related to other behaviours seen by Magik for example here in the lotus-dev channel.

While everyone usually points to SplitStore as a potential source for "removing" these messages, I think @ZenGround0 latest adventures into the SplitStore code in: #12803 made him convinced that these cases are not SplitStore issues at all, because messages are not stored in the splitstore but the metadata store.

I do not think it is great that we do not have a understanding of why people are excessively seeing these logs, but I´m not sure if we have bandwidth to dive into it at this moment in time. I will create a tracking/investigation ticket for the overarching issue of ipld: could not find logs/issues.

@rjan90 rjan90 merged commit 37096c3 into master Feb 20, 2025
83 checks passed
@rjan90 rjan90 deleted the phi/reduce-log-level-slashvc branch February 20, 2025 08:46
@rjan90
Copy link
Contributor Author

rjan90 commented Feb 20, 2025

I will reuse/add more comments to this ticket here: #10260 as it seems somewhat related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants