-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Cats 0.8.0 and beyond #78
Comments
@od0 That would be a tremendous help. I was going to look at this over the holidays, but if you've got the bandwidth I'd love a PR. This needs to happen sooner rather than later for sure. |
@penland365 I think I may have volunteered a bit too quickly :) getting the Xor's migrated to Either is a bit beyond my bandwidth at the moment. Might be better to tackle it with a big version upgrade instead - e.g. Circe (0.5.0-M2 => 0.6.1 or 0.7 when it's ready) and Finagle (6.38.0 => 6.41.0). The latest Finagle release was a big one as it unlocks supporting Scala 2.12 (where Either is right-biased like Xor) - one more thing for what is seeming like a bigger PR :) |
@penland365 I took a quick crack and resolved most of the Xor => Either issues, but there's still compile errors which I wasn't able to immediately resolve. I opened a PR which you can contribute too as well - hope that helps in some small way :) |
With version 0.8.0, Cats sunsetted
Xor
. This raises conflicts when using Roc alongside libraries that have migrated to Cats 0.8.0+ (e.g. https://github.com/finagle/finch)There are only a handful of occurrences to convert to
Either
- I can submit a PR if that would helpThe text was updated successfully, but these errors were encountered: