Show appropriate date when date is part of grouped data on chart. #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszenz
reviewed
Nov 25, 2024
…elected Signed-off-by: Onesimus Wiafe <[email protected]>
Co-authored-by: asrar <[email protected]> Signed-off-by: Onesimus Wiafe <[email protected]>
onesimus-wiafe
force-pushed
the
plugin/fix_epoch_time_to_date_on_axis_label
branch
from
d23bc03 to
2f967db
Compare
Signed-off-by: Onesimus Wiafe <[email protected]>
Signed-off-by: Onesimus Wiafe <[email protected]>
texodus
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thanks for the PR!
I suspect some parts of this PR are AI generated. We do not yet have an official project policy on this, but I'm not eager to review such code. If you're going to use these tools, please rigorously check for relevance, brevity and sanity before submitting - technically correct code is not enough. If this is not AI generated code - please do this anyway.
Regardless of the tooling, I would like some cleanup of this code before we merge it (see review comments).
Signed-off-by: Onesimus Wiafe <[email protected]>
Signed-off-by: Onesimus Wiafe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2566. When the data is grouped and a date is part of the grouped data, the date values are then represented in epoch format. I couldn't figure out the exact source of the problem, and this solution addresses the problem. I included a function in the filter.ts file since all the plugins affected by this issue import the functions in filter.ts. I refine the date type values before the functions in filter.ts run. The tests included confirm this solution too.
Pull Request Checklist
Discussions, this PR applies to.