From d8c5a44bac3afac2c9f2b6c4e4d49d464b241609 Mon Sep 17 00:00:00 2001 From: Andrew Laucius Date: Thu, 9 Jan 2025 12:49:01 -0500 Subject: [PATCH] Removed dependency on wait_for_up as that is now part of the start action --- tests/framework/microvm.py | 21 ------------------- .../functional/test_snapshot_basic.py | 2 -- 2 files changed, 23 deletions(-) diff --git a/tests/framework/microvm.py b/tests/framework/microvm.py index 00bafe10cae..1208e6d2380 100644 --- a/tests/framework/microvm.py +++ b/tests/framework/microvm.py @@ -1069,27 +1069,6 @@ def _dump_debug_information(self, exc: Exception): f"Thread backtraces:\n{self.thread_backtraces}" ) - def wait_for_up(self, timeout=10): - """Wait for guest running inside the microVM to come up and respond. - - :param timeout: seconds to wait. - """ - try: - rc, stdout, stderr = self.ssh.run("true", timeout) - except subprocess.TimeoutExpired: - print( - f"Remote command did not respond within {timeout}s\n\n" - f"Firecracker logs:\n{self.log_data}\n" - f"Thread backtraces:\n{self.thread_backtraces}" - ) - raise - assert rc == 0, ( - f"Remote command exited with non-0 status code\n\n" - f"{rc=}\n{stdout=}\n{stderr=}\n\n" - f"Firecracker logs:\n{self.log_data}\n" - f"Thread backtraces:\n{self.thread_backtraces}" - ) - def wait_for_ssh_up(self): """Wait for guest running inside the microVM to come up and respond.""" # Ensure that we have an initialized SSH connection to the guest that can diff --git a/tests/integration_tests/functional/test_snapshot_basic.py b/tests/integration_tests/functional/test_snapshot_basic.py index df79c7a832d..0557ced1b7b 100644 --- a/tests/integration_tests/functional/test_snapshot_basic.py +++ b/tests/integration_tests/functional/test_snapshot_basic.py @@ -556,7 +556,6 @@ def test_snapshot_rename_interface(uvm_nano, microvm_factory): vm.add_net_iface(iface=iface1) # Create an interface but don't attach it to the device vm.start() - vm.wait_for_up() snapshot = vm.snapshot_full() @@ -569,4 +568,3 @@ def test_snapshot_rename_interface(uvm_nano, microvm_factory): snapshot, rename_interfaces={base_iface.dev_name: "tap2"} ) restored_vm.resume() - restored_vm.wait_for_up()