Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing return in fd_wksp_usage error case #2349

Open
0x0ece opened this issue Jul 9, 2024 · 2 comments
Open

Missing return in fd_wksp_usage error case #2349

0x0ece opened this issue Jul 9, 2024 · 2 comments
Labels
Priority: Medium security Security relevant

Comments

@0x0ece
Copy link
Contributor

0x0ece commented Jul 9, 2024

The error case here is missing a return:
https://github.com/firedancer-io/firedancer/blob/d714efac3f33aeb97fffe1eeb1a06b556c6323a0/src/util/wksp/fd_wksp_user.c#L572C1-L577C1
@0x0ece 0x0ece added security Security relevant Priority: Medium labels Jul 9, 2024
@kbowers-jump
Copy link
Contributor

Will fix in the wksp-checkpt branch (since there is a lot of stuff already getting updated there).

@kbowers-jump
Copy link
Contributor

Fixed in the kbowers-jump/wksp-checkpt branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium security Security relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0x0ece @kbowers-jump