New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd_shred_parse permits merkle shreds with zero nodes #2539

Open

ripatel-fd opened this issue Jul 30, 2024 · 1 comment

Assignees

Labels

Priority: Medium

Contributor

ripatel-fd commented Jul 30, 2024

This shred (type 0x60) passes fd_shred_parse but has a fd_shred_merkle_cnt()==0.

crash-8bdd1c27b700692796bd4730a519c41028b406c1.zip

Contradicts the documentation of fd_shred_merkle_cnt:

/* fd_shred_merkle_cnt: Returns number of nodes in the merkle inclusion
   proof.  Note that this excludes the root.  Returns zero if the given
   shred is not a merkle variant. */

ripatel-fd assigned ptaffet-jump

ripatel-fd added the Priority: Medium label

Contributor Author

ripatel-fd commented Jul 30, 2024

When fixed, please update fuzz_shred_parse.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment