From 59c9121cd8e23ffcfa916a5169bbfbd64a611d08 Mon Sep 17 00:00:00 2001 From: Linus Arver Date: Sun, 30 Jun 2024 19:56:55 +1000 Subject: [PATCH] WELCOME.md: warn new users against copy/pastign CC lists Copy/pasting Markdown-formatted CC lists from one GGG PR to another can result in a broken CC list which needs manual fixing from the maintainer. So warn users about this issue early on for all first-time contributors. See [1] for a discussion of some of the ways the community would like to mitigate this issue (one of which is the motivation for this change). [1] https://lore.kernel.org/git/xmqqle2o26jy.fsf@gitster.g/ --- res/WELCOME.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/res/WELCOME.md b/res/WELCOME.md index f35b74a393..b5b1302501 100644 --- a/res/WELCOME.md +++ b/res/WELCOME.md @@ -11,6 +11,10 @@ You can CC potential reviewers by adding a footer to the PR description with the CC: Revi Ewer , Ill Takalook +NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description, +because it will result in a malformed CC list on the mailing list. See +[example](https://lore.kernel.org/git/owly4jd741ph.fsf@fine.c.googlers.com/). + Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form: * the lines should not exceed 76 columns,