Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the amount of protected attribute access #16

Open
fjarri opened this issue Jul 27, 2024 · 0 comments
Open

Reduce the amount of protected attribute access #16

fjarri opened this issue Jul 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fjarri
Copy link
Owner

fjarri commented Jul 27, 2024

There is a large number of places where we access protected attributes of other classes, marked by noqa: SLF001 so that Ruff doesn't complain. Are all of those really necessary? Seems like a code smell.
@fjarri fjarri added the enhancement New feature or request label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fjarri