Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin support on flatpak #122

Open
MaledictYtb opened this issue Jan 8, 2025 · 6 comments
Open

Plugin support on flatpak #122

MaledictYtb opened this issue Jan 8, 2025 · 6 comments

Comments

@MaledictYtb
Copy link

Issue
When installing the flatpak version of mumble, there's no plugin installed by default.
I've tried to install them manually, but couldn't figure it out.
I've find two issues related :
mumble-voip/mumble#5993
mumble-voip/mumble#6523

This feature is really important, since mumble is used in a lot of video games for proximity chat.
It's also a big issue for immutable distro, which can only use the flatpak version of mumble.

Solution
The solution would be to implement plugins in the flatpak version.
I've read that it is not possible to use shared memory due to the flatpak sandbox, but maybe it is possible now ?

@jbruechert
Copy link
Collaborator

jbruechert commented Jan 8, 2025

Do you know a simple to get game that I could test this with? I have never used this functionality, so I don't really know how it works.

Shared memory is at least not impossible to use in flatpak.

@jbruechert
Copy link
Collaborator

Can you try whether #123 works for you?

@Hartmnt
Copy link

Hartmnt commented Jan 8, 2025

AFAIK, allowing shared memory needs to be enabled "on both ends". So for a native game, that should be no problem. But I assume, if the games are to be played through Steam Flatpak for example, the user would need to enable shared memory for that, too. Which is not ideal from a security perspective. Especially since Steam Games are effectively arbitrary Code.

That being said, there is/was ongoing effort to move part of the overlay somewhere else such that it could be used in a sandboxed context: mumble-voip/mumble#5961 (See also the linked pull request for Steam Flatpak regarding discord)

Maybe something like this could be achieved for the plugins as well. But I am currently not deep enough into Flatpaks and positional audio plugins to give a final answer on that. We are definitely open for contributions that would make PA available for Mumble Flatpak.

@MaledictYtb
Copy link
Author

MaledictYtb commented Jan 8, 2025

I'm using PA in Minecraft using Mumble Link mod.
It works fine with your flatpak build #123 with default permisssions and minecraft running natively on the system (outside of flatpak)

With Minecraft in flatpak, it doesn't work by default. I need to add the Shared memory permission for Minecraft using Flatseal.
It seems to work fine but if I restart Minecraft, Mumble crashed with this error :
terminate called after throwing an instance of 'std::range_error' what(): wstring_convert::to_byte

@jbruechert
Copy link
Collaborator

In that case, I'll merge my PR.

@MaledictYtb
Copy link
Author

Is there anything such as a debug mode so I can look more into why it's crashing with other flatpak apps ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants