Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent case for error prefix #104

Open
BenBE opened this issue Aug 25, 2021 · 2 comments
Open

Consistent case for error prefix #104

BenBE opened this issue Aug 25, 2021 · 2 comments
Labels
chore Things that need to happen but don't change the behaviour enhancement New feature or request good first issue Good for newcomers

Comments

@BenBE
Copy link
Collaborator

BenBE commented Aug 25, 2021

In error messages the case for writing error should be consistent. There seem to be places with ERROR:, Error: and error: in the code. Maybe we should decide for one of those variants and use it consistently.

@BenBE BenBE added enhancement New feature or request good first issue Good for newcomers labels Aug 25, 2021
@phlash
Copy link
Collaborator

phlash commented Aug 25, 2021

We might be at the mercy of various libraries - I note with distaste that many parts of OpenCV print directly to stderr rather than use the provided error logging facility (which applications can intercept/format etc.) - but yep, our stuff should be consistent 😄

@phlash phlash added the chore Things that need to happen but don't change the behaviour label Aug 25, 2021
@BenBE
Copy link
Collaborator Author

BenBE commented Aug 25, 2021

For htop the stderr is completely redirected into a memfd and only ever dumped to the real stderr on abnormal exit. We may think about doing something similar here too. But that is another issue if we decide to go that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Things that need to happen but don't change the behaviour enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants