Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages are there own dependents #206

Closed
dschrempf opened this issue Sep 15, 2022 · 1 comment
Closed

Packages are there own dependents #206

dschrempf opened this issue Sep 15, 2022 · 1 comment

Comments

@dschrempf
Copy link

Hi!

Thank you for this excellent website! Especially the reverse dependency feature is exciting! (Did you think about package metrics such as download rate? https://crates.io does a good job in that respect, I think.)

I saw that packages show up as their own "Dependents" (should we use "Reverse dependencies"?). For example, the package circular shows up in its dependents here: https://flora.pm/packages/@hackage/circular.

I was a bit surprised about this feature! Is this behavior desired?

Thank you!

@tchoutri
Copy link
Contributor

Hi @dschrempf!

  1. Did you think about package metrics such as download rate?

Yes I have, and it would power the next version of the search engine. See #4

  1. Is this behavior desired?

Looks to me like this should be a custom "ignore" rule, because Flora actually scans all the components of all the releases, and you'll see that your test suite actually depends on circular: https://github.com/dschrempf/circular/blob/master/circular.cabal#L51 :)

So, I don't think we should filter out every test-suite component, but we certainly can filter out the package name itself from its own dependents. :)

@flora-pm flora-pm locked and limited conversation to collaborators Sep 15, 2022
@tchoutri tchoutri converted this issue into discussion #207 Sep 15, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants