Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional TemperatureClient to redirect temperature readings another HA entity #22

Closed
wants to merge 57 commits into from

Conversation

matthewturner
Copy link

Fixes #17, #19

I've been working on a fork for a while. I'm not sure if any of the changes are of interest but there may be some useful bits.

  • Separated out components into discreet classes
  • Added an optional TemperatureClient and Client wrapper to redirect temperature readings to another entity via the Home Assistant API
  • Switched all calls to async
  • Fixed various deprecation warnings
  • Added run.py script for testing locally
  • Added simulator classes
  • Added unit tests
  • Added devcontainers for running unit tests in VS Code
  • Added Github CI

matthewturner and others added 30 commits December 14, 2023 22:08
* Added the option to quickly reload it from dev tools

* Update climate.py

replaced deprecated consts

* Update climate.py

* Update climate.py

Remove long text from log

* Add asyncio

* Make unit tests pass

* Remove custom_components climate.py

* Bump version number

---------

Co-authored-by: Dan Timu <[email protected]>
Co-authored-by: aver-ua <[email protected]>
Co-authored-by: floringhimie <[email protected]>
* Added the option to quickly reload it from dev tools

* Update climate.py

replaced deprecated consts

* Update climate.py

* Update climate.py

Remove long text from log

* Add asyncio

* Make unit tests pass

* Remove custom_components climate.py

* Bump version number

---------

Co-authored-by: Dan Timu <[email protected]>
Co-authored-by: aver-ua <[email protected]>
Co-authored-by: floringhimie <[email protected]>
@romicaiarca
Copy link

romicaiarca commented Feb 27, 2024

I have installed your component and On run I have the following log message:

climate:
  - platform: salusfy
    username: "email"
    password: "password"
    id: "salusDeviceId"
    enable_temperature_client: False

And it looks like the integration is looking for access_token and entity_id. They should be set as optional and they should be required only if enable_temperature_client: True

To make the integration work, I had to add this into my config:

climate:
  - platform: salusfy
    access_token: "your-HA-access-token"
    entity_id: "your-entity"
    username: "email"
    password: "password"
    id: "salusDeviceId"
    enable_temperature_client: False

@matthewturner
Copy link
Author

Ah thanks, I hadn't tested without those values. I've made them optional now.

What was the log message you got?

@romicaiarca
Copy link

romicaiarca commented Feb 27, 2024

Ah thanks, I hadn't tested without those values. I've made them optional now.

What was the log message you got?

Logger: homeassistant.config
Source: config.py:1293
First occurred: 10:50:55 AM (2 occurrences)
Last logged: 10:50:55 AM

Invalid config for 'climate' from integration 'salusfy' at custom_configs/salufy.yaml, line 2: required key 'access_token' not provided, please check the docs at https://github.com/floringhimie/salusfy Invalid config for 'climate' from integration 'salusfy' at custom_configs/salufy.yaml, line 2: required key 'entity_id' not provided, please check the docs at https://github.com/floringhimie/salusfy

I will try to fork and make a HACS compatible component from your fork with am instalation UI, in order to make the component more flexible and no pass passwords through config files.

@matthewturner
Copy link
Author

I've just removed the extra settings from configuration.yaml and confirmed it now works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V0.0.3 not workig
2 participants