Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friction parameter is read at the top-level of YAML config file #126

Open
clement-moulin-frier opened this issue Feb 12, 2025 · 0 comments

Comments

@clement-moulin-frier
Copy link
Collaborator

Whereas it should be within an entity description (see example below).

Also, no error is raised when we define an entity field in the YAML that does not exist in the class datastructure. This is error prone (e.g. one could set friction there, as in the second yaml below, but currently it just ignores it and set the default value instead).

To check if there are similar issues for other parameters.

To define friction in the YAML currently we do:

friction: 0.25

entities_data:
  EntitySubTypes:
    - PREYS
    - PARTICLES

    PREYS:
      ...

    PARTICLES:
      type: OBJECT
      num: 200

Whereas we should do (if e.g. we want to have different friction in different entity subtypes):

entities_data:
  EntitySubTypes:
    - PREYS
    - PARTICLES

    PREYS:
      ...

    PARTICLES:
      type: OBJECT
      num: 200
      friction: 0.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant