Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: "write" and "read" without path name opening the file GUI. #294

Open
zomoipotoi opened this issue Jan 23, 2025 · 7 comments
Labels
bug Something isn't working

Comments

@zomoipotoi
Copy link

Please tell us what you were doing! You can include code and files by drag and dropping them into the text area.

Hi, I'm using Flucoma on Pure Data and noticed that "write" method on MLPregressor is available but do nothing.
I've checked code in MLPRegressorClient.hpp and I noticed that method 'write' is not implemented.
Since I'm not at all a c++ expert, I could be wrong. In this case sorry for the noise.

What was the expected result?

The expected result is that, in Pure Data, I can save to file regressor data.

What was the actual result?

Now, in Pure Data, if I send message "write" to fluid.mlpregressor nothing happens.

What operating system were you using?

Windows

Operating system version

Windows 10

FluCoMa Version

1.0.6

@zomoipotoi zomoipotoi added the bug Something isn't working label Jan 23, 2025
@tremblap
Copy link
Member

as per documentation, the write message needs to be followed by the path. on Max we managed to use the app's file GUI, but we didn't in Pd. @weefuzzy did we explore that and it was just too complicated?

in the meantime, @zomoipotoi write the path and you're golden. I'll change this thread to a feature request.

@tremblap tremblap changed the title Bug: MLPregressor "write" method not implemented Feature Request: "write" and "read" without path name opening the file GUI. Jan 23, 2025
@weefuzzy
Copy link
Member

No memory of this, sorry. If there's pd API calls that get us the dialogue boxes, then we can look into it.

@zomoipotoi
Copy link
Author

zomoipotoi commented Jan 23, 2025

Hi, many thanks for the prompt answer.
I'm really happy with the solution you proposed: write the path.
I've tested it just now and it works.
I've also tested yesterday using a path pointing to a non existent file and it didn't work. Today I've created the file before to click "write c:\xxxx.json" and now it is working.
Thanks a lot again for your great work!!!
Bye

@tremblap
Copy link
Member

oh it is strange that writing to a non-existant file doesn't work. that would be a bug. let me test that.

@zomoipotoi
Copy link
Author

zomoipotoi commented Jan 23, 2025

Sorry... I tested again now and it is working as expected!
Maybe yesterday I used a wrong path.

@tremblap
Copy link
Member

here too, so we're all good. If we find an API call to support a dialogue box for file browsing we'll check - but I just looked and I couldn't find it in the API so don't hold your breath :)

@zomoipotoi
Copy link
Author

I'm very satisfied with current situation. I don't really need the dialog box, I only need the possibility to store data and reload data when the patch is opened.
So I'm breathing deep now, starting using mlpregressor in true projects and exploring better your library, trying to understand more complex objects available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants