Detach from KeyDown event to match code in Show() #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will try to release a new version tomorrow. |
batzen
added a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written,
Backstagewill attach to theKeyDownevent of the owning window but later detach from thePreviewKeyDownevent. This creates a memory leak where theBackstageinstance (and everything else referenced from it) will be kept in memory for as long as the owning window, via theKeyDownevent. In our application the appearance of the main window changes according to which mode the application is in, with the ribbon control part of the visual tree in only one of these modes. In this (perhaps slightly unusual) setup, simply opening the backstage will cause the application to leak memory. This PR aims to solve this problem by detaching from theKeyDownevent inRestoreParentPropertiesas was, presumably, the original intent.