Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separators no longer shown in Backstage #1070

Closed
MarcelVersteeg opened this issue Oct 6, 2022 · 3 comments · Fixed by #1072
Closed

Separators no longer shown in Backstage #1070

MarcelVersteeg opened this issue Oct 6, 2022 · 3 comments · Fixed by #1072
Assignees
Labels

Comments

@MarcelVersteeg
Copy link

I just upgraded Fluent.Ribbon from version 8.0.1 to version 9.0.4. Now my separators are no longer shown in the Backstage and the tab headers are also no longer aligned (they indent further with every separator).

In my XAML I use a styled System.Windows.Controls.Separator for the separator. Even if I do not set the Style attribute, the separator is not shown and the tab header do not align correctly in version 9.0.4 while it was with version 8.0.1. If I replace the System.Windows.Controls.Separator with an unstyled Fluent.SeparatorTabItem, the separators do show in the default color and the items correctly align, but I want to give the separators another color. Setting the Foreground or Background properties of the SeparatorTabItem does not work and if apply the style I previously used for the System.Windows.Controls.Separator (changing the type to apply it to to Fluent.SeparatorTabItem), the separator disappears again and the items are no longer aligned.

How can I change the color of the separator in the backstage?


Environment

  • Fluent.Ribbon 9.0.4
  • Windows 10
  • .NET Framework 4.6.2
@batzen
Copy link
Member

batzen commented Oct 6, 2022

You can still use a regular Separator.
You just have to set DockPanel.Dock="Top" on them.

The panel for the backstage was changed to be a DockPanel while fixing #936.
I totally forgot to add this to the list of breaking changes, as setting the dock alignment is now mandatory, as the default in WPF is Left.

@MarcelVersteeg
Copy link
Author

That indeed did the trick. Thank you for the quick response!

@batzen batzen reopened this Oct 8, 2022
@batzen batzen self-assigned this Oct 8, 2022
@batzen batzen added the Bug 🐞 label Oct 8, 2022
@batzen
Copy link
Member

batzen commented Oct 8, 2022

I will change the code to automatically set the default dock value for all items added to the backstage.
That way people don't have to set it, if they want the default layout (top to bottom).

batzen added a commit that referenced this issue Oct 8, 2022
batzen added a commit that referenced this issue Oct 15, 2022
#1070 Separators no longer shown in Backstage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants