Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing menu font size in Windows mess ups ribbon #55

Closed
pekspro opened this issue Jan 24, 2015 · 8 comments
Closed

Changing menu font size in Windows mess ups ribbon #55

pekspro opened this issue Jan 24, 2015 · 8 comments
Assignees
Milestone

Comments

@pekspro
Copy link
Contributor

pekspro commented Jan 24, 2015

It’s possible to change the menu font size in the screen settings in Windows. But this could mess up the Ribbon quite a bit I think. It could look like this:

menufonterror

Personally I think it’s a good idea to respect the Window settings, but maybe not in this case. Interestingly the ribbon in Office 2013 do this, but not the ribbon used in Windows 8 (and also in Windows 10 preview).

@batzen
Copy link
Member

batzen commented Jan 28, 2015

This collides with #28
But now I'm no longer sure if it was a good idea to accept the PR connected to that issue...
Getting dynamic font sizes to work correctly in all conditions seems impossible and introduces a lot of problems in many areas.

@batzen
Copy link
Member

batzen commented Jan 28, 2015

@innostory I fear i will have to revert everything changed in your PR and any subsequent changes which were done to support dynamic font sizing. Any thoughts from your side?

@yakiro-nvg
Copy link

This is a requirement from my client, so if you refuse to support it, I will have some trouble :d I agree that it may be impossible because we don't thinking about scaling from beginning, so it hard to do it correctly.

But it still is a good requirements. I don't know why MS drop it in Win8 and Win10 preview, it hard to say this to my client as the reason :(

@pekspro
Copy link
Contributor Author

pekspro commented Jan 30, 2015

I also like the idea about making things larger automatically as long as I could disable it :-).

However, it doesn’t need to be that hard if the problem is solved with a different approach. WPF by itself has really good support for scaling and if that is used instead of changing font size on a tons places this may be achieved relative easily. I added this in the test project to make everything 25% larger and its looks just fine:

    <Fluent:Ribbon AutomaticStateManagement="True"
                   x:Name="ribbon"
                   RenderTransformOrigin="0,0">
        <Fluent:Ribbon.RenderTransform>
            <TransformGroup>
                <ScaleTransform ScaleX="1.25"
                                ScaleY="1.25" />
                <SkewTransform />
            </TransformGroup>
        </Fluent:Ribbon.RenderTransform>

@batzen
Copy link
Member

batzen commented Jan 30, 2015

Making it possible to disable the feature adds even more complexity and room for error, so i will just remove it completely.

You are totally correct.
You got multiple choice to scale your WPF UI.

  1. Just tell your clients to use the Windows DPI settings.
  2. Add a LayoutTransform to your Window. A RenderTransform will cause problems.
    One thing to note when using a ScaleTransform as a LayoutTransform is to change the TextOptions.TextFormattingModeProperty from Display to Ideal when your zoom is != 1.0

@batzen batzen added this to the 3.3.0 milestone Jan 30, 2015
@batzen batzen self-assigned this Jan 30, 2015
@batzen
Copy link
Member

batzen commented Jan 30, 2015

I reverted all changes made to support SystemFonts with commit 3938dba

@batzen batzen closed this as completed Jan 30, 2015
@pekspro
Copy link
Contributor Author

pekspro commented Jan 30, 2015

I must correct myself even if it doesn’t change anything. The ribbon in Windows 8 actually does change its size when the menu size is changed. I must did something wrong first time I tested this.

@batzen
Copy link
Member

batzen commented Feb 1, 2015

I already reverted the changes and won't add them back because i can't support everything related to dynamic font sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants