-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing menu font size in Windows mess ups ribbon #55
Comments
This collides with #28 |
@innostory I fear i will have to revert everything changed in your PR and any subsequent changes which were done to support dynamic font sizing. Any thoughts from your side? |
This is a requirement from my client, so if you refuse to support it, I will have some trouble :d I agree that it may be impossible because we don't thinking about scaling from beginning, so it hard to do it correctly. But it still is a good requirements. I don't know why MS drop it in Win8 and Win10 preview, it hard to say this to my client as the reason :( |
I also like the idea about making things larger automatically as long as I could disable it :-). However, it doesn’t need to be that hard if the problem is solved with a different approach. WPF by itself has really good support for scaling and if that is used instead of changing font size on a tons places this may be achieved relative easily. I added this in the test project to make everything 25% larger and its looks just fine:
|
Making it possible to disable the feature adds even more complexity and room for error, so i will just remove it completely. You are totally correct.
|
I reverted all changes made to support SystemFonts with commit 3938dba |
I must correct myself even if it doesn’t change anything. The ribbon in Windows 8 actually does change its size when the menu size is changed. I must did something wrong first time I tested this. |
I already reverted the changes and won't add them back because i can't support everything related to dynamic font sizes. |
It’s possible to change the menu font size in the screen settings in Windows. But this could mess up the Ribbon quite a bit I think. It could look like this:
Personally I think it’s a good idea to respect the Window settings, but maybe not in this case. Interestingly the ribbon in Office 2013 do this, but not the ribbon used in Windows 8 (and also in Windows 10 preview).
The text was updated successfully, but these errors were encountered: