Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizeDefinition property of RibbonControls in RibbonToolBar is not reflected in layout #929

Closed
nishy2000 opened this issue May 5, 2021 · 0 comments · Fixed by #930
Closed
Labels
Milestone

Comments

@nishy2000
Copy link
Contributor

SizeDefinition property of RibbonControls in RibbonToolBar is not reflected in layout

How to reporoduce:

  1. Add the following code as new RibbonTabItem in TestContent.xaml.
<Fluent:RibbonTabItem Header="Ribbon controls in panel"
                                  ReduceOrder="PanelGroup11,PanelGroup11,PanelGroup11,PanelGroup11"
                                  KeyTip="P">
    <Fluent:RibbonGroupBox x:Name="PanelGroup11"
                       Header="In RibbonToolBar"
                       LauncherText="launcher"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Green.png"
                       IsSeparatorVisible="True"
                       IsLauncherVisible="True">

    <Fluent:RibbonToolBar>
        <Fluent:Button Header="Full(L/L/S) button"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Gray.png"
                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/GrayLarge.png"
                       SizeDefinition="Large,Large,Small"/>
        <Fluent:Button Header="Full(M/M/S) button"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Yellow.png"
                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/YellowLarge.png"
                       SizeDefinition="Middle,Middle,Small"/>
        <Fluent:Button Header="Full(L/L/L) button"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Orange.png"
                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/OrangeLarge.png"
                       SizeDefinition="Large"/>
        <Fluent:Button Header="Full(default) button"
                       Icon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/Brown.png"
                       LargeIcon="pack://application:,,,/Fluent.Ribbon.Showcase;component/Images/BrownLarge.png" />
        </Fluent:RibbonToolBar>
    </Fluent:RibbonGroupBox>
</Fluent:RibbonTabItem>
  1. Start Fulent.Ribbon.Showcase
  2. Show a added new ribbon tab item
  3. SizeDefinition property of RibbonControls in RibbonToolBar is not reflected in layout when showing at first and when changing State property of RibbonGroupBox

Environment

  • Fluent.Ribbon 9.0.0 preview (latest develop branch [69f4464])
  • Windows 10 Pro 20H2
  • .NET Framework 4.6.2 / net5.0-windows
nishy2000 added a commit to nishy2000/Fluent.Ribbon that referenced this issue May 5, 2021
batzen added a commit that referenced this issue May 5, 2021
…tion

Fix for #929 (SizeDefinition reflection issue of controls in RibbonToolBar)
@batzen batzen added the Bug 🐞 label May 5, 2021
batzen added a commit that referenced this issue May 5, 2021
@batzen batzen added this to the 9.0 milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants