Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3 Bug - Pawn isDisfigured throws error and fails job (temp fix already found) #33

Open
whitegrimreaper opened this issue Aug 31, 2021 · 1 comment

Comments

@whitegrimreaper
Copy link

Describe the bug
When two pawns are finishing Lovin', there is a logged error relating to Rimworld's IsDisfigured check, causing the action to fail. This means the pawns do not receive a mood buff for the lovin, and they will repeatedly re-attempt every night many times, leading to limited sleeping time

Expected behavior
This shouldn't be happening

Steps to reproduce

  1. Have game with two pawns in a relationship and sharing a bed
  2. During the night they should attempt Lovin'

Other mods

I have many other mods installed, but none should have issues here

Output log

https://gist.github.com/8a35930fdb85be5c6aa5ff50b40a86e4

Relevant log lines:
Pawn Luci threw exception while executing toil's finish action (2), jobDriver=RimWorld.JobDriver_Lovin, job=Lovin (Job_448539) A=Thing_Human204 B=Thing_DoubleBed52663, toilIndex=3: System.MissingMethodException: bool RimWorld.RelationsUtility.IsDisfigured(Verse.Pawn)
at Fluffy_BirdsAndBees.JobDriver_Lovin_MakeNewToils_FinishAction.Prefix (RimWorld.JobDriver_Lovin __instance) [0x00046] in <561edd0ab41e41bbb8fed9c3ea169ed9>:0
at (wrapper dynamic-method) RimWorld.JobDriver_Lovin.RimWorld.JobDriver_Lovin.b__11_4_Patch1(RimWorld.JobDriver_Lovin)
at Verse.AI.Toil.Cleanup (System.Int32 myIndex, Verse.AI.JobDriver jobDriver) [0x0001f] in :0
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Save game

I have many mods, so I don't really think a savegame would be that productive

Screenshots

It's just an error log so i will save your eyes

Environment

  • OS:
  • 32/64 bits
    W10, x64

Game

  • 32/64 bits
  • Steam/DRM free
  • Version

64, Steam, 1.3.3102

I already know a temporary fix for this:
You can likely just remove the check in LovinUtility.cs (line 41) that deals with disfigurement, this should solve the bug at least temporarily. Plus I think it's a lot nicer to not let disfigurement affect the quality of Lovin' in any case. Otherwise there may be some way to include ideologies with this mod, but this bandaid fix should be fine.

@whitegrimreaper
Copy link
Author

I just gave the fix a try myself, removing that check does in fact fix the bug and cause the correct mood debuff to show up afterwards. I can put in a PR or something if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant