Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property Editor] Ensure DTD APIs are available before calling them #8715

Closed
elliette opened this issue Jan 14, 2025 · 3 comments · Fixed by #8788
Closed

[Property Editor] Ensure DTD APIs are available before calling them #8715

elliette opened this issue Jan 14, 2025 · 3 comments · Fixed by #8788
Labels
P2 important to work on, but not at the top of the work list. property editor

Comments

@elliette
Copy link
Member

See comment here: #8598 (comment)

@elliette elliette added P2 important to work on, but not at the top of the work list. property editor labels Jan 14, 2025
@elliette
Copy link
Member Author

@DanTup Where / when is the initialized event being sent? (I'm wondering it it's possible it's sent before DevTools connects to the DTD connection.)

@DanTup
Copy link
Contributor

DanTup commented Jan 17, 2025

hmm, this might be an oversight...

The event is sent by the server after it registers all of the LSP handlers. However both of these will happen well before you connect. When you connect to DTD, we transmit all registered services so you know they're available, but because initialized is an event, there's no re-transmission of that.

I don't know if it makes sense to re-transmit events like this, because this event was quite LSP-specific. Ignoring initialized, a client generally wouldn't want to know that DTD has finished sending it the existing services, because in general there's nothing to say new services won't be registered milliseconds later.

I wonder if the simplest thing would be for the property editor to just show a spinner until it has the services it expects registered, perhaps with a timeout (of a few seconds) that says no editor is available? In theory, no users should see this because the editors shouldn't be showing a property editor iframe when those services would not be available?

@elliette
Copy link
Member Author

Sounds good, opened #8788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 important to work on, but not at the top of the work list. property editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants