From eec1ba427f6a9cf54e44906837b8446172697fec Mon Sep 17 00:00:00 2001 From: "zijiehe@" <68449066+zijiehe-google-com@users.noreply.github.com> Date: Wed, 6 Nov 2024 12:57:10 -0800 Subject: [PATCH] Roll ICU from 9408c6fd4a39 to 4239b1559d11 (2 revisions) (#56407) Redo #56401 with a manual license change to remove the chromeos/icudtl.dat.hash. The file was removed by https://crrev.com/83a7bd47a345137ac6081c71c2a7158f5403cd30. Original change description: https://chromium.googlesource.com/chromium/deps/icu.git/+log/9408c6fd4a39..4239b1559d11 2024-10-02 [dayeung@chromium.org](mailto:dayeung@chromium.org) Updated TZ to 2024b 2024-09-05 [andreaorru@chromium.org](mailto:andreaorru@chromium.org) Remove icudtl.dat.hash If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter-engine Please CC [fuchsia-ui-discuss@google.com](mailto:fuchsia-ui-discuss@google.com),[jsimmons@google.com](mailto:jsimmons@google.com) on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style --- DEPS | 2 +- ci/licenses_golden/licenses_flutter | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/DEPS b/DEPS index ff09875db237b..7d93f6efb086e 100644 --- a/DEPS +++ b/DEPS @@ -285,7 +285,7 @@ deps = { Var('chromium_git') + '/external/github.com/google/flatbuffers' + '@' + '0a80646371179f8a7a5c1f42c31ee1d44dcf6709', 'src/flutter/third_party/icu': - Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '9408c6fd4a39e6fef0e1c4077602e1c83b15f3fb', + Var('chromium_git') + '/chromium/deps/icu.git' + '@' + '4239b1559d11d4fa66c100543eda4161e060311e', 'src/flutter/third_party/gtest-parallel': Var('chromium_git') + '/external/github.com/google/gtest-parallel' + '@' + '38191e2733d7cbaeaef6a3f1a942ddeb38a2ad14', diff --git a/ci/licenses_golden/licenses_flutter b/ci/licenses_golden/licenses_flutter index e35f4f66585ac..3bc4ca203e554 100644 --- a/ci/licenses_golden/licenses_flutter +++ b/ci/licenses_golden/licenses_flutter @@ -59084,7 +59084,6 @@ FILE: ../../../flutter/third_party/icu/android/icudtl.dat FILE: ../../../flutter/third_party/icu/cast/brkitr.patch FILE: ../../../flutter/third_party/icu/cast/icudtl.dat FILE: ../../../flutter/third_party/icu/chromeos/icudtl.dat -FILE: ../../../flutter/third_party/icu/chromeos/icudtl.dat.hash FILE: ../../../flutter/third_party/icu/common/icudtb.dat FILE: ../../../flutter/third_party/icu/common/icudtl.dat FILE: ../../../flutter/third_party/icu/flutter/brkitr.patch