Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Missing note: The file should be recompiled using Visual Studio for the changes to take effect #11391

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add Missing note: The file should be recompiled using Visual Studio for the changes to take effect #11391

wants to merge 2 commits into from
+5 −1

Conversation

AbdeMohlbi
Copy link

@AbdeMohlbi AbdeMohlbi commented Nov 12, 2024 •
edited
Loading

fixes: #11390

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

sfshaza2
sfshaza2 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbdeMohlbi, thanks very much for this great contribution! I made a few style changes, but otherwise, LGTM

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 07b533a):

https://flutter-docs-prod--pr11391-patch-1-b6p9uoae.web.app

@AbdeMohlbi
Copy link
Author

AbdeMohlbi commented Nov 13, 2024 •
edited
Loading

@AbdeMohlbi, thanks very much for this great contribution! I made a few style changes, but otherwise, LGTM

Hey @sfshaza2, thanks for your attention!

What concerns me is the error message that mentions a "memory leak." I tried debugging but couldn't find any leak. Is this expected?
Also i prefer to mention visual studio so devs won't try to recompile the project on there ide ( AS,intellij,vsCode).

@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review November 13, 2024 18:14
@AbdeMohlbi AbdeMohlbi requested review from parlough and a team as code owners November 13, 2024 18:14
@AbdeMohlbi AbdeMohlbi changed the title add Missing note: The file should be compiled using Visual Studio for the changes to take effect add Missing note: The file should be recompiled using Visual Studio for the changes to take effect Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@parlough parlough Awaiting requested review from parlough parlough is a code owner

@RedBrogdon RedBrogdon Awaiting requested review from RedBrogdon RedBrogdon is a code owner automatically assigned from flutter/website-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing note: The file should be recompiled using Visual Studio for the changes to take effect.
3 participants
@AbdeMohlbi @sfshaza2 @flutter-website-bot