Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow web favicon to be built from a different source image file #515

Open
galenwarren opened this issue Sep 20, 2023 · 1 comment
Open

Comments

@galenwarren
Copy link

💬 Description

It would be useful to be able to use a different source image to generate the favicon vs. the image icons for Flutter web. Two reasons:

  • Favicons with transparent backgrounds work well, in general, but transparent backgrounds don't work well for icons for PWA apps (a background gets assigned which might be white, might be black, etc.)
  • PWA icons have the same issue that Android icons do, i.e. adaptive icons need to limit content to the "safe zone" so that the icons can be cropped as needed. Favicons don't need this extra padding and really can't afford to have it, given how small they are to begin with.

I'm proposing to add an image_path_favicon option to the config to allow one to override the source icon used to generate the favicon. This would allow one to specify a non-padded icon with a transparent background to use for favicon generation and a padded icon with a solid-color background for other image generation.

I have this working locally in a fork and would be happy to submit a PR. Thanks!

❓ Platform

Is this feature request for a specific platform? E.g. Web / iOS / Android / Mac OS / Windows / Linux
Web

@galenwarren
Copy link
Author

Created PR: #519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant