Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14) #2529

Closed
8 tasks done
luisredondo opened this issue Jan 23, 2024 · 3 comments · Fixed by #2588, #2589, #2590, #2591 or #2592
Closed
8 tasks done

[Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14) #2529

luisredondo opened this issue Jan 23, 2024 · 3 comments · Fixed by #2588, #2589, #2590, #2591 or #2592
Labels
bug Something isn't working triage

Comments

@luisredondo
Copy link
Contributor

luisredondo commented Jan 23, 2024

Description

Flutter actively replaces targets 10.11 and 10.13 in their source code. Reference: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/macos/migrations/macos_deployment_target_migration.dart#L51

They did a whole doc explaining why to stop support for 10.13: https://docs.google.com/document/d/1wHqr2cob78VfUKhOFEKjaUM_mnV4gL-mg3gSQCFhF7Y/edit

Here is another issue tracking the progress of the update, where it highlights platforms that will lose support if minimun target is >10.13: flutter/flutter#114445

I think the minimum target for MacOS should be bump in all the plus_plugins to the minimum one that the latest stable version supports, since the warning is there for a reason, which it's probably to prevent unexpected behavior.

I can implement this if you agree with the bumping!

Platform

macos

Plugin

connectivity_plus

Version

connectivity_plus: ^5.0.2

Flutter SDK

3.16.5

Steps to reproduce

Steps to reproduce the behavior:

  1. Create a flutter default project with the latest stable version.
  2. Add connectivity_plus as dependency.
  3. flutter run -d macos
  4. Look at the console and we should see what listed in Logs.

Code Sample

No response

Logs

/Users/user/flutter_project/macos/Pods/Pods.xcodeproj: warning: The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.11, but the range of supported deployment target versions is 10.13 to 14.2.99. (in target 'ReachabilitySwift' from project 'Pods')

Flutter Doctor

[✓] Flutter (Channel stable, 3.16.5, on macOS 14.0 darwin-arm64, locale
    en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.85.2)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Checklist before submitting a bug

  • I searched issues in this repository and couldn't find such bug/problem
  • I Google'd a solution and I couldn't find it
  • I searched on StackOverflow for a solution and I couldn't find it
  • I read the README.md file of the plugin
  • I'm using the latest version of the plugin
  • All dependencies are up to date with flutter pub upgrade
  • I did a flutter clean
  • I tried running the example project
@luisredondo luisredondo added bug Something isn't working triage labels Jan 23, 2024
@luisredondo luisredondo changed the title [Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.13) [Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14) Jan 23, 2024
@vbuberen
Copy link
Collaborator

Thanks for catching this and providing a detailed information about the reasoning.

Considering that min supported in this table: https://docs.flutter.dev/reference/supported-platforms is also 10.14 as it is noted in the document you shared, I agree with the need to bump min iOS for all plugins.

I can implement this if you agree with the bumping!

Sure, go ahead. But please create a separate PR for every plugin for flexibility, so we don't have to run the whole set of CI checks for all plugins at once.

@vbuberen
Copy link
Collaborator

vbuberen commented Feb 8, 2024

Hey @luisredondo
Could you share if there are plan to create such PRs in some nearest time or later?
Asking, because I would like to release this change of min support MacOS as a major version bump and, ideally, I would like to combine some other breaking change PRs together, like #2508 to not increase major version many times.

@luisredondo
Copy link
Contributor Author

Hey @luisredondo Could you share if there are plan to create such PRs in some nearest time or later? Asking, because I would like to release this change of min support MacOS as a major version bump and, ideally, I would like to combine some other breaking change PRs together, like #2508 to not increase major version many times.

Hey @vbuberen! I will do it later today. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment