-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14) #2529
Comments
Thanks for catching this and providing a detailed information about the reasoning. Considering that min supported in this table: https://docs.flutter.dev/reference/supported-platforms is also 10.14 as it is noted in the document you shared, I agree with the need to bump min iOS for all plugins.
Sure, go ahead. But please create a separate PR for every plugin for flexibility, so we don't have to run the whole set of CI checks for all plugins at once. |
Hey @luisredondo |
Hey @vbuberen! I will do it later today. 🙌 |
Description
Flutter actively replaces targets 10.11 and 10.13 in their source code. Reference: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/macos/migrations/macos_deployment_target_migration.dart#L51
They did a whole doc explaining why to stop support for 10.13: https://docs.google.com/document/d/1wHqr2cob78VfUKhOFEKjaUM_mnV4gL-mg3gSQCFhF7Y/edit
Here is another issue tracking the progress of the update, where it highlights platforms that will lose support if minimun target is >10.13: flutter/flutter#114445
I think the minimum target for MacOS should be bump in all the
plus_plugins
to the minimum one that the latest stable version supports, since the warning is there for a reason, which it's probably to prevent unexpected behavior.I can implement this if you agree with the bumping!
Platform
macos
Plugin
connectivity_plus
Version
connectivity_plus: ^5.0.2
Flutter SDK
3.16.5
Steps to reproduce
Steps to reproduce the behavior:
connectivity_plus
as dependency.flutter run -d macos
Logs
.Code Sample
No response
Logs
Flutter Doctor
Checklist before submitting a bug
flutter pub upgrade
flutter clean
The text was updated successfully, but these errors were encountered: