Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app scanner for ActionCable should check if the config needs Redis #96

Open
albus522 opened this issue May 3, 2024 · 1 comment

Comments

@albus522
Copy link
Collaborator

albus522 commented May 3, 2024

Right now, if ActionCable is being using, we try to add redis even if ActionCable is not configured to use redis. It would be better to make the check a bit smarter in determining if redis is actually required.

@rubys
Copy link
Collaborator

rubys commented May 3, 2024

Take a peek at https://github.com/fly-apps/dockerfile-rails/blob/main/lib/dockerfile-rails/scanner.rb, and look for references to anycable.

Also, you can experiment with:

bin/rails console
> YAML.load_file('config/cable.yml')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants