Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subreddits or Search notifications not working #5

Open
i486 opened this issue Feb 10, 2020 · 6 comments
Open

Subreddits or Search notifications not working #5

i486 opened this issue Feb 10, 2020 · 6 comments

Comments

@i486
Copy link

i486 commented Feb 10, 2020

PM notification works fine. But i never received any notification from the subreddit or search feature.

Here is my setting

Subreddits
Watch for new posts in the following subreddits
buildapcsales

I am trying to get firefox notification for every new posts from the subreddit buildapcsales

Search
Watch for specific posts in this subreddit
Name: empty
Subreddit: buildapcsales
Search query: author:redditusername123

I am trying to get firefox notification everytime redditusername123 posts in the subreddit buildapcsales

Can you tell me what i am doing wrong?

@flytaly
Copy link
Owner

flytaly commented Feb 10, 2020

Do you have new posts in the popup? If the only thing you don't have is notifications, I think you didn't select this checkbox
Capture
and this
Capture

It's disabled by default.

@i486
Copy link
Author

i486 commented Mar 27, 2020

Do you have new posts in the popup? If the only thing you don't have is notifications, I think you didn't select this checkbox
Capture
and this
Capture

It's disabled by default.

I didn't receive any popup/notifications with my settings above. Also I didn't check "Show desktop notifications ..." because i wasn't trying to receive desktop notifications. i was trying to receive notification only when i am using Firefox like how "Watch for new Reddit Mail" feature works. Not possible?

dom.webnotifications.enabled = 0

@flytaly
Copy link
Owner

flytaly commented Mar 27, 2020

It's called "desktop notification" because it uses the operating system's notification mechanism not because it works outside Firefox. It is literally the same as notification about new mail.

@i486
Copy link
Author

i486 commented Mar 28, 2020

My bad. I thought it's some kind of Windows desktop notification that shows even though user hasn't opened the browser. You know like the Chrome notification or Windows 10 native notification ,etc which i really hate. I really should have tested it lol. It's working!

Anyways, I have one question and a feature request.

Question:

What's difference between "Watch for new reddit mail" and "Show desktop notifications of new mail"? I had only "Watch for new reddit mail" checked and i was receiving new pm notification fine on firefox.

Request:

So now i am receiving new post notifications. I'd like to go to https://www.reddit.com/r/subreddit/new/ by clicking on the notification. Like how "Watch for new Reddit mail" notification goes to inbox when we click on the notification. New post notification currently just closes when clicked.

@flytaly
Copy link
Owner

flytaly commented Mar 28, 2020

"Watch for new reddit mail" means that extension check for unread mail and shows their amount in the badge:
Screenshot 2020-03-28 at 03 11 44

"Show desktop notifications" is something like this:
65182768-080f0c00-da30-11e9-92e3-3ac75789f464

Request:

I will update the extension soon to support Firefox 75 (April 7) authorization changes and most likely add this feature as well.

@i486
Copy link
Author

i486 commented Mar 30, 2020

I am on Windows 7. That probably explains some of my confusion/difference. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants