Update glog 1.2.0 -> 1.2.4 - CVE-2024-45339 #6301
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run #3f7165Actionable Suggestions - 0Review Details
AI Code Review powered by |
Signed-off-by: ddl-ebrown <[email protected]>
Changelist by BitoThis pull request implements the following key changes.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6301 +/- ##
=======================================
Coverage 58.48% 58.49%
=======================================
Files 937 937
Lines 71088 71088
=======================================
+ Hits 41577 41583 +6
+ Misses 26359 26353 -6
Partials 3152 3152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Code Review Agent Run #8a6dcbActionable Suggestions - 0Review Details
AI Code Review powered by |
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
ddl-ebrown
commented
Mar 4, 2025
| @@ -145,8 +145,6 @@ github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69 | |||
| github.com/golang-jwt/jwt/v5 v5.2.1 h1:OuVbFODueb089Lh128TAcimifWaLhJwVflnrgM17wHk= | |||
| github.com/golang-jwt/jwt/v5 v5.2.1/go.mod h1:pqrtFR0X4osieyHYxtmOUWsAWrfe1Q5UVIyoH402zdk= | |||
| github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q= | |||
| github.com/golang/glog v1.2.0 h1:uCdmnmatrKCgMBlM4rMuJZWOkPDqdbZPnrMXDY4gI68= | |||
There was a problem hiding this comment.
Ahh thanks @eapolinario I was wondering what tooling had to be used to cleanup the CI fails
Code Review Agent Run #c0ed0eActionable Suggestions - 0Review Details
AI Code Review powered by |
eapolinario
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6200
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This PR updates the glog dependency from v1.2.0 to v1.2.4 across multiple modules to address security vulnerability CVE-2024-45339. The changes are implemented in go.mod and go.sum files for datacatalog, flyteadmin, and the root project, with necessary checksum entries added and obsolete entries removed to maintain integrity and properly reference the updated secure version.Unit tests added: False
Estimated effort to review (1-5, lower is better): 1