Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI break in locale_ref ctor (11.0.0 -> 11.1.1) #4292

Open
jengelh opened this issue Jan 5, 2025 · 3 comments
Open

ABI break in locale_ref ctor (11.0.0 -> 11.1.1) #4292

jengelh opened this issue Jan 5, 2025 · 3 comments

Comments

@jengelh
Copy link

jengelh commented Jan 5, 2025

Commit ff92223 changed:

-  template <typename Locale> explicit locale_ref(const Locale& loc);
+
+  template <typename Locale, FMT_ENABLE_IF(sizeof(Locale::collate) != 0)>
+  locale_ref(const Locale& loc);

which is an ABI change for platforms like amd64-gnu-linux:

-_ZN3fmt3v116detail10locale_refC1ISt6localeEERKT_
+_ZN3fmt3v116detail10locale_refC1ISt6localeLi0EEERKT_

I am reporting this because ABI seems to be important to fmtlib (cf. commit 3e04222).
ABI break observed by end-user at https://bugzilla.suse.com/show_bug.cgi?id=1235078 .

@vitaut
Copy link
Contributor

vitaut commented Jan 8, 2025

This was non-intentional, will look into restoring the ABI compatibility. Thanks for reporting!

@vitaut
Copy link
Contributor

vitaut commented Jan 11, 2025

The ABI compatibility should be restored by 21aa095 which effectively reverts ff92223. @jengelh, could you confirm that it resolves the issue (then we'll make a patch release)?

@jengelh
Copy link
Author

jengelh commented Jan 11, 2025

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants