Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denmark: Christmas naming wrong #201

Open
derTobsch opened this issue Mar 21, 2023 · 2 comments
Open

denmark: Christmas naming wrong #201

derTobsch opened this issue Mar 21, 2023 · 2 comments
Labels
country: denmark status: ideal-for-contribution An issue that a contributor can help us with topic: public holiday type: bug Something isn't working

Comments

@derTobsch
Copy link
Contributor

derTobsch commented Mar 21, 2023 •
edited
Loading

Names of the holidays on December 25 and 26 are incorrect. I would argue that the English Wikipedia also has the incorrect names. In Danish they are litterally called first and second christmas day (perhaps with the first it is often just called christmas day). I can see that there is a first and second Christmas day name

jollyday/jollyday-core/src/main/resources/descriptions/holiday_descriptions.properties

Lines 306 to 307 in eb88454

holiday.description.FIRST_CHRISTMAS_DAY = 1st Christmas day
holiday.description.SECOND_CHRISTMAS_DAY = 2nd Christmas day

refs #191
@derTobsch derTobsch mentioned this issue Mar 21, 2023
Closed
@derTobsch derTobsch added the status: ideal-for-contribution An issue that a contributor can help us with label Jun 20, 2023
@derTobsch
Copy link
Contributor Author

derTobsch commented Sep 14, 2023 •
edited
Loading

Good morning @AndreasPetersen,

just to have more information about your issue. Which language do you use? Do you use danish in your application? Or do you use English?

@AndreasPetersen
Copy link

Danish, English and German. But we don't actually use or display these names in our application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
country: denmark status: ideal-for-contribution An issue that a contributor can help us with topic: public holiday type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreasPetersen @derTobsch