You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please add support for above holiday type, as this would make definition for e.g. the Queen's official Birthday in the Cayman Islands (usually the Monday after the second Saturday in June), Bermuda Day (the Friday before the last Monday in May), Emancipation Day (the Thursday before the first Monday in August), Somers Day (the Friday before the first Monday in August) or Mary Prince Day (the Friday before the first Monday in August) in Bermuda way easier.
The text was updated successfully, but these errors were encountered:
When thinking about it, one should actually be able to catch all cases above with FixedWeekdayBetweenFixed, though one has to do quite some calculating for that manually.
It's effectively the same for the T.T. Bank Holiday in Isle of Man: it's the Friday after the first Monday in June, which always has to be the Friday between the 5th and 11th of June.
@derTobsch How much work do you expect it to be to implement FixedWeekdayRelativeToWeekday?
Even though it would maybe not be necessary, I would nevertheless highly appreciate this element, because it would free oneself from the tedious work.
The more I think about it the calculations aren't that complicated, I was only thinking way to complicated before.
But the implementation of FixedWeekdayRelativeToWeekday should be very simple to realize as well. After all, one just hast to take the existing FixedWeekday and just apply a fixed offset depending on the desired weekday and whether it is before or after the day that it is relative to.
For now I changed the definitions in Bermuda to use FixedWeekdayBetweenFixed (see #342), though this is way less descriptive to what is actually the case, where a FixedWeekdayRelativeToWeekday whould actually help. It in the end is just the same kind of syntactic sugar that FixedWeekday provides, that after all could also always be expressed with FixedWeekdayBetweenFixed.
More information
Please add support for above holiday type, as this would make definition for e.g. the Queen's official Birthday in the Cayman Islands (usually the Monday after the second Saturday in June), Bermuda Day (the Friday before the last Monday in May), Emancipation Day (the Thursday before the first Monday in August), Somers Day (the Friday before the first Monday in August) or Mary Prince Day (the Friday before the first Monday in August) in Bermuda way easier.
The text was updated successfully, but these errors were encountered: