Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese lunisolar calendar #285

Open
XSpielinbox opened this issue Aug 28, 2023 · 4 comments
Open

Add Chinese lunisolar calendar #285

XSpielinbox opened this issue Aug 28, 2023 · 4 comments
Labels
status: new Initial state for every issue / pull request topic: calendar type: enhancement A general enhancement

Comments

@XSpielinbox
Copy link
Contributor

XSpielinbox commented Aug 28, 2023

More information

Please add support for the Chinese calendar, as this would significantly simplify the definitions for many holidays, e.g.

When one wants to add China, this would of course be very useful too.

@XSpielinbox XSpielinbox added the status: new Initial state for every issue / pull request label Aug 28, 2023
@derTobsch derTobsch added the type: enhancement A general enhancement label Sep 6, 2023
@derTobsch derTobsch changed the title Support Chinese lunisolar calendar Add Chinese lunisolar calendar Sep 6, 2023
@derTobsch
Copy link
Contributor

I did not take a deeper look, but maybe https://github.com/MenoData/Time4J is something for us until java will provide, I have no idea if they ever will, a chinese lunarsolar calendar

@XSpielinbox
Copy link
Contributor Author

I did not take a deeper look, but maybe https://github.com/MenoData/Time4J is something for us until java will provide, I have no idea if they ever will, a chinese lunarsolar calendar

I did not take a deeper look either, but it looks promising.

@allosmt
Copy link

allosmt commented Jan 17, 2024

Hello guys,
any news about this feature, is something planned?

Thanks

@derTobsch
Copy link
Contributor

Hello guys, any news about this feature, is something planned?

Thanks

Not really planned ATM. But the Chinese Holidays are available. The lunisolar calendar would only make the configuration easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: new Initial state for every issue / pull request topic: calendar type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants